Repository navigation
Work around iiasa/ixmp4#272 - #654
Merged
Merged
Conversation
khaeru
force-pushed
the
ci/ixmp4-272
branch
from
September 29, 2026 15:15
9e2d792 to
cccfc5e
Compare
khaeru
force-pushed
the
ci/ixmp4-272
branch
from
September 29, 2026 15:19
cccfc5e to
ae98ce8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #654 +/- ##
=======================================
+ Coverage 98.4% 98.5% +0.1%
=======================================
Files 55 55
Lines 6756 6767 +11
=======================================
+ Hits 6650 6669 +19
+ Misses 106 98 -8
🚀 New features to boost your workflow:
|
khaeru
force-pushed
the
ci/ixmp4-272
branch
from
September 29, 2026 15:29
ae98ce8 to
6d6d7db
Compare
khaeru
force-pushed
the
ci/ixmp4-272
branch
from
September 29, 2026 16:19
6d6d7db to
39f3ddb
Compare
khaeru
force-pushed
the
ci/ixmp4-272
branch
from
September 29, 2026 16:52
39f3ddb to
f2f369e
Compare
2 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to khaeru/genno#205.
This PR adjusts in the following ways:
.util.ixmp4.has_ixmp4(), a general-purpose function to check whether ixmp4 is not only installed but also importable without raising an exception; use this instead of similar code in a few places..testing.MARK["ixmp4-importable"]for tests that will fail if ixmp4 is not importable; apply this to some tests. These include tests that import pyam, which always imports ixmp4 and thus triggers SQLAlchemy dependency issue ixmp4#272.Through the above, we ensure that Pytest can start, load the plugin
ixmp.testing, and run tests, even when ixmp4 raises exceptions on import. This means that the scheduled CI runs for ixmp itself should not fail if upstream pyam or ixmp4 break, for whatever reason. However, this in turn means we don't get as clear/obvious signal when such breakage occurs, and will need to keep an eye for it, for instance when merging PRs.How to review
PR checklist
Add, expand, or update documentation.N/A; CI changes onlyUpdate release notes.ditto