feat: resolve MDI source spans - #75
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve_mdi_source_spanresolution from half-open UTF-8 source spans to canonical block/grapheme rangesRelated issue
Closes #74.
Validation
cargo fmt --checkcargo clippy -- -D warningscargo testcargo llvm-cov --locked --fail-under-lines 90 --fail-under-functions 90 --fail-under-regions 90 --summary-onlypnpm install --frozen-lockfilepnpm typecheckpnpm buildpnpm test:browser(Chromium, Firefox, WebKit)node --test nodejs/scripts/pack-publishable-package.test.mjspnpm test:coverageChecklist
Notes for reviewers
The projection wire shape and
MDI_TEXT_PROJECTION_VERSIONremain1.0; this adds a separate result boundary without changing the existing projection envelope. Package versions are intentionally left to the repository's post-merge release workflows.