Skip to content

chore: re-enable fail-on-error for coverage upload - #18

Merged
dkattan merged 2 commits into
mainfrom
chore/enable-code-quality
Jul 28, 2026
Merged

chore: re-enable fail-on-error for coverage upload#18
dkattan merged 2 commits into
mainfrom
chore/enable-code-quality

Conversation

@dkattan

@dkattan dkattan commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Repo transferred to the immense org where Code Quality is available. The code-coverage/report endpoint now returns 422 (not 404), confirming the feature is active.

Changes:

  • Set fail-on-error: true on actions/upload-code-coverage@v1 so CI fails when coverage upload fails

Follow-up to PRs #13 and #14 which added coverage reporting but had to disable fail-on-error due to the 404.

Test and others added 2 commits July 28, 2026 09:07
…GIT_EDITOR

- Fix Split-Commit creating one piece per hunk instead of grouping by PieceNumber
  across multiple files in a single commit
- Add -AutoResolveConflicts to Move-Commit for modify/delete conflicts during
  source rebase (auto-removes files created by the moved commit)
- Set GIT_EDITOR/GIT_SEQUENCE_EDITOR during Move-Commit rebase to prevent
  interactive editor hangs in non-interactive environments

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Repo transferred to immense org where Code Quality is available.
The code-coverage/report endpoint now returns 422 (not 404), confirming
the feature is active.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 28, 2026 14:45
@dkattan
dkattan merged commit f529828 into main Jul 28, 2026
1 check failed
@dkattan
dkattan deleted the chore/enable-code-quality branch July 28, 2026 14:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Intended to make coverage upload failures fail CI, but also includes unrelated module changes and CodeQL setup.

Changes:

  • Enables coverage upload failure enforcement.
  • Adds a CodeQL workflow.
  • Expands commit splitting/moving behavior and tests.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.

File Description
.github/workflows/ci.yml Enables fail-on-error.
.github/workflows/codeql.yml Adds CodeQL analysis.
GitSplit.psm1 Modifies Git operations and APIs.
GitSplit.Tests.ps1 Adds split/move tests.

Comment thread GitSplit.psm1
Comment thread GitSplit.psm1
Comment thread GitSplit.psm1
Comment thread GitSplit.psm1
Comment thread GitSplit.psm1
Comment thread .github/workflows/codeql.yml
Comment thread GitSplit.psm1
Comment thread GitSplit.psm1
Comment thread GitSplit.Tests.ps1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants