Skip to content

createQuad/Cylinder/Equirect/CubeLayer init param cannot be optional #314

Description

@toji

The layers spec shows that the init param to the creation functions for most layer types is optional, defaulting to {}. However each of these init types are inherited from XRLayerInit dictionary, which has three required args:

As a result these params should not be marked as optional. It seems like we can probably just remove the optional qualifier from each of them and everything will be fine, since anyone trying to use them without args previously was almost certain to be receiving an error from the browser about not providing all the necessary fields anyway.

Worth noting that createProjectionLayer() SHOULD keep it's init parameter optional, as there's no required fields.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions