feat: add SQLite ORM backend via ncruces/go-sqlite3 by Copilot · Pull Request #278 · infinilabs/framework

Copilot · 2026-04-18T07:17:46Z

BatchMutateAPI was part of the ORM surface but was not covered by interface-level tests. This change adds explicit guards so DeleteByQuery remains part of the contract with the expected signature.

Contract coverage
- add a test asserting ORM continues to embed BatchMutateAPI
- prevent accidental interface drift when composing the top-level ORM API
Batch mutate API coverage
- add a test asserting BatchMutateAPI exposes DeleteByQuery
- verify the full method shape:
  - inputs: *Context, *QueryBuilder
  - outputs: *DeleteByQueryResponse, error
Why this matters
- catches silent breaking changes to the batch mutation contract
- makes the DeleteByQuery API an explicit, enforced part of the public ORM surface

batchMutateType := reflect.TypeOf((*BatchMutateAPI)(nil)).Elem()
method, ok := batchMutateType.MethodByName("DeleteByQuery")

Implement a lightweight SQLite-based ORM storage backend as an alternative to the existing Elasticsearch backend. The new module follows the same orm.ORM interface pattern and is registered via orm.Register("sqlite", handler). Key features: - JSON document storage with SQLite json_extract for queries - Full ORM interface: CRUD, Search, SearchV2, DeleteByQuery - QueryBuilder to SQL WHERE clause translation - WAL mode for concurrent read performance - Comprehensive test coverage (17 tests) Agent-Logs-Url: https://github.com/infinilabs/framework/sessions/c7adba2d-c701-4bd0-9c10-ec59d79b4ae0 Co-authored-by: medcl <64487+medcl@users.noreply.github.com>

- Remove redundant variable assignment in RegisterSchemaWithName - Fix Search and SearchWithResultItemMapper to return correct total count via separate COUNT query instead of counting fetched rows Agent-Logs-Url: https://github.com/infinilabs/framework/sessions/c7adba2d-c701-4bd0-9c10-ec59d79b4ae0 Co-authored-by: medcl <64487+medcl@users.noreply.github.com>

This file is in .gitignore and should not be tracked. It is generated by the build process. Co-authored-by: medcl <64487+medcl@users.noreply.github.com>

Agent-Logs-Url: https://github.com/infinilabs/framework/sessions/f6db8347-448d-4d9b-a129-f1a526faf6e8 Co-authored-by: medcl <64487+medcl@users.noreply.github.com>

…tterns Add 12 new tests covering the complex nested query patterns used by the security search operation hook (RegisterSearchOperationHook): - Must wrapping ShouldQuery with minimum_should_match - Owner-only queries (no sharing) - Should with shared resource IDs - Category filter with owner - Nested BooleanQuery inside Should (folder access + deny rules) - Should with MustNot folder deny rules - Dotted field paths (_system.owner_id, _system.parent_path) - Filter with MustQuery wrapper - Full search hook simulation with all patterns combined - Multiple folder allow/deny paths - Category children sharing - Empty ShouldQuery edge case Agent-Logs-Url: https://github.com/infinilabs/framework/sessions/8d394cd4-0c76-4a0e-9db1-f463b0a2006f Co-authored-by: medcl <64487+medcl@users.noreply.github.com>

Agent-Logs-Url: https://github.com/infinilabs/framework/sessions/8d394cd4-0c76-4a0e-9db1-f463b0a2006f Co-authored-by: medcl <64487+medcl@users.noreply.github.com>

…e ORM Add 7 new integration tests verifying the SQLite backend correctly handles the patterns used by RegisterDataOperationPreHook for Create, Update, and Save operations: - System field round-trip (Create with _system.owner_id, Get, verify) - Update preserving system fields after deserialization - Save (upsert) with SystemFieldAccessor interface - GetOwnerID and Object/SystemFieldAccessor interface after SQLite deserialization - SearchV2 filtering by _system.owner_id via json_extract - SearchV2 with ShouldQuery combining owner OR shared IDs - DeleteByQuery filtering by _system.owner_id Also add missing constants to config/generated.go for build compatibility. Agent-Logs-Url: https://github.com/infinilabs/framework/sessions/39670c0d-37f0-4903-969b-1c006bf7cdab Co-authored-by: medcl <64487+medcl@users.noreply.github.com>

Agent-Logs-Url: https://github.com/infinilabs/framework/sessions/39670c0d-37f0-4903-969b-1c006bf7cdab Co-authored-by: medcl <64487+medcl@users.noreply.github.com>

Update clauseToSQL to properly read and respect the minimum_should_match parameter from clause.Parameters: - When minimum_should_match >= 1: should clauses are required (OR join) - When only 1 should clause with min_should_match=1: treat as mandatory (no unnecessary OR wrapping) - When minimum_should_match is unset and no must/filter exist: default to requiring at least 1 match (Elasticsearch semantics) - When minimum_should_match is unset with must/filter present: should clauses are optional (scoring-only in ES, safely skipped in SQLite) Add unit tests: - SingleShouldMinShouldMatch1_IsMandatory - SingleShouldWithFilterAndMinShouldMatch1 - OptionalShouldWithoutMinShouldMatch Add integration test: - SearchV2_SingleShouldOwnerIsMandatory (end-to-end with real SQLite DB) Agent-Logs-Url: https://github.com/infinilabs/framework/sessions/dc353da8-ad60-4779-86ff-b7a7e5d614d2 Co-authored-by: medcl <64487+medcl@users.noreply.github.com>

Agent-Logs-Url: https://github.com/infinilabs/framework/sessions/dc353da8-ad60-4779-86ff-b7a7e5d614d2 Co-authored-by: medcl <64487+medcl@users.noreply.github.com>

This file is gitignored and regenerated at build time by the Makefile. The LastFrameworkCommitLog and LastFrameworkVendorCommitLog constants are generated separately into config/generated_framework-info.go. Agent-Logs-Url: https://github.com/infinilabs/framework/sessions/3922a466-05d7-40bf-8429-fc6e3821230d Co-authored-by: medcl <64487+medcl@users.noreply.github.com>

medcl · 2026-05-30T08:16:32Z

@copilot resolve the merge conflicts in this pull request

…ackend-support # Conflicts: # go.mod # go.sum

Copilot · 2026-05-30T08:18:45Z

@copilot resolve the merge conflicts in this pull request

Resolved the merge conflicts in go.mod and go.sum. Kept the tetratelabs/wazero dependency (needed for ncruces/go-sqlite3) and updated tklauser/go-sysconf and tklauser/numcpus to the newer versions from main. Merge commit: 2b4366c7.

Copilot AI and others added 2 commits April 18, 2026 05:13

Copilot AI assigned Copilot and medcl Apr 18, 2026

Copilot created this pull request from a session on behalf of medcl April 18, 2026 07:17 View session

medcl changed the title ~~Add SQLite ORM backend via ncruces/go-sqlite3~~ feat: add SQLite ORM backend via ncruces/go-sqlite3 Apr 18, 2026

Copilot started work on behalf of medcl April 18, 2026 07:32 View session

chore: remove generated.go from version control

5f87f58

This file is in .gitignore and should not be tracked. It is generated by the build process. Co-authored-by: medcl <64487+medcl@users.noreply.github.com>

Copilot AI requested a review from medcl April 18, 2026 07:34

Copilot finished work on behalf of medcl April 18, 2026 07:34

Copilot started work on behalf of medcl April 18, 2026 07:55 View session

Restore config/generated.go with previous values

7fc8eb7

Agent-Logs-Url: https://github.com/infinilabs/framework/sessions/f6db8347-448d-4d9b-a129-f1a526faf6e8 Co-authored-by: medcl <64487+medcl@users.noreply.github.com>

Copilot finished work on behalf of medcl April 18, 2026 07:58

Copilot started work on behalf of medcl April 18, 2026 08:18 View session

Copilot finished work on behalf of medcl April 18, 2026 08:20

Copilot started work on behalf of medcl April 18, 2026 16:15 View session

Copilot finished work on behalf of medcl April 18, 2026 16:17

Copilot started work on behalf of medcl April 18, 2026 16:17 View session

Copilot AI and others added 2 commits April 18, 2026 16:25

docs: clarify test comment for search hook query pattern tests

06b35ec

Agent-Logs-Url: https://github.com/infinilabs/framework/sessions/8d394cd4-0c76-4a0e-9db1-f463b0a2006f Co-authored-by: medcl <64487+medcl@users.noreply.github.com>

Copilot finished work on behalf of medcl April 18, 2026 16:30

Copilot started work on behalf of medcl April 18, 2026 23:50 View session

Copilot AI and others added 2 commits April 18, 2026 23:56

test: verify SQLite ORM supports security hook query patterns

73220c1

Agent-Logs-Url: https://github.com/infinilabs/framework/sessions/39670c0d-37f0-4903-969b-1c006bf7cdab Co-authored-by: medcl <64487+medcl@users.noreply.github.com>

Copilot finished work on behalf of medcl April 19, 2026 00:01

Copilot started work on behalf of medcl April 19, 2026 01:15 View session

Copilot AI and others added 2 commits April 19, 2026 01:22

SQLite query builder: respect minimum_should_match semantics

44e1220

Agent-Logs-Url: https://github.com/infinilabs/framework/sessions/dc353da8-ad60-4779-86ff-b7a7e5d614d2 Co-authored-by: medcl <64487+medcl@users.noreply.github.com>

Copilot finished work on behalf of medcl April 19, 2026 01:27

Copilot started work on behalf of medcl April 19, 2026 01:43 View session

Copilot finished work on behalf of medcl April 19, 2026 01:46

Merge branch 'main' into copilot/add-sqlite3-backend-support

705c536

Copilot started work on behalf of medcl May 30, 2026 08:16 View session

Merge remote-tracking branch 'origin/main' into copilot/add-sqlite3-b…

2b4366c

…ackend-support # Conflicts: # go.mod # go.sum

Copilot finished work on behalf of medcl May 30, 2026 08:19

Copilot started work on behalf of medcl May 30, 2026 08:34 View session

test(sqlite): add nested query coverage

92c0e01

Copilot AI changed the title ~~feat: add SQLite ORM backend via ncruces/go-sqlite3~~ test(sqlite): expand CRUD and nested query coverage May 30, 2026

Copilot finished work on behalf of medcl May 30, 2026 08:38

medcl marked this pull request as ready for review May 30, 2026 10:24

Copilot started work on behalf of medcl June 1, 2026 02:19 View session

Copilot AI added 2 commits June 1, 2026 02:22

chore: outline batch mutate api test update

7899e44

test: cover batch mutate api interface

2d12e17

Copilot AI changed the title ~~test(sqlite): expand CRUD and nested query coverage~~ Add interface coverage for BatchMutateAPI.DeleteByQuery Jun 1, 2026

Copilot finished work on behalf of medcl June 1, 2026 02:25

medcl changed the title ~~Add interface coverage for BatchMutateAPI.DeleteByQuery~~ feat: add SQLite ORM backend via ncruces/go-sqlite3 Jun 1, 2026

chore: revert generated.go

1a37027

SteveLauC approved these changes Jun 1, 2026

View reviewed changes

medcl merged commit 30f3943 into main Jun 1, 2026
3 of 4 checks passed

medcl deleted the copilot/add-sqlite3-backend-support branch June 1, 2026 10:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add SQLite ORM backend via ncruces/go-sqlite3#278

feat: add SQLite ORM backend via ncruces/go-sqlite3#278
medcl merged 17 commits into
mainfrom
copilot/add-sqlite3-backend-support

Copilot AI commented Apr 18, 2026 •

edited

Loading

Uh oh!

medcl commented May 30, 2026

Uh oh!

Copilot AI commented May 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

medcl commented May 30, 2026

Uh oh!

Copilot AI commented May 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 18, 2026 •

edited

Loading