feat: add login challenge security helpers#369
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@copilot add a |
|
|
||
| challenge, ok := store.challenges[challengeID] | ||
| if !ok { | ||
| return Challenge{}, errors.New("login challenge is invalid") |
There was a problem hiding this comment.
| return Challenge{}, errors.New("login challenge is invalid") | |
| return Challenge{}, errors.New("login challenge not found") |
Agent-Logs-Url: https://github.com/infinilabs/framework/sessions/ab9e4b17-e2e4-4f0f-9c33-50bb89a93c77 Co-authored-by: medcl <64487+medcl@users.noreply.github.com>
| Method = "challenge" | ||
| Algorithm = "PBKDF2-SHA256" |
There was a problem hiding this comment.
给调用者使用的
Agent-Logs-Url: https://github.com/infinilabs/framework/sessions/ab9e4b17-e2e4-4f0f-9c33-50bb89a93c77 Co-authored-by: medcl <64487+medcl@users.noreply.github.com>
Agent-Logs-Url: https://github.com/infinilabs/framework/sessions/ab9e4b17-e2e4-4f0f-9c33-50bb89a93c77 Co-authored-by: medcl <64487+medcl@users.noreply.github.com>
Agent-Logs-Url: https://github.com/infinilabs/framework/sessions/ab9e4b17-e2e4-4f0f-9c33-50bb89a93c77 Co-authored-by: medcl <64487+medcl@users.noreply.github.com>
Agent-Logs-Url: https://github.com/infinilabs/framework/sessions/ab9e4b17-e2e4-4f0f-9c33-50bb89a93c77 Co-authored-by: medcl <64487+medcl@users.noreply.github.com>
Implemented via commit |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ed-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Follow-up changes related to the native account challenge rollout have been pushed to this PR branch:
These are the framework-side compatibility changes needed while console is still converging onto the shared auth/session stack. |
…t <223556219+Copilot@users.noreply.github.com>
|
Additional follow-up for the same rollout has now been pushed:
This is the next step toward removing console-owned |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Follow-up for the shared account-flow rollout:
This keeps the native account management path aligned with the earlier challenge-login/account-flow changes in this PR. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Follow-up for the shared account-flow rollout:
This is the cleanup pass after the earlier account-flow convergence work in this PR. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Small structure cleanup for reviewability:
The console bridge keeps using the same hooks, but the framework side now reads as normal registry/session extension instead of a migration-specific file. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Follow-up reviewability cleanup:
This keeps the auth flow behavior the same for valid users while making error semantics and migration intent clearer for review. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Follow-up simplification after confirming the rollout only targets new console + new framework together:
This reduces review noise and keeps the framework token model product-neutral. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Summary
Included scope
core/security/passwordchallenge/*core/security/replay/*core/api/security.goand its testsExplicitly excluded
core/api/web.goandcore/api/api.gowork fromconsole_framework