Skip to content

Update example decorators - #291

Draft
wangben718 wants to merge 47 commits into
devfrom
update-example-decorators
Draft

Update example decorators#291
wangben718 wants to merge 47 commits into
devfrom
update-example-decorators

Conversation

@wangben718

@wangben718 wangben718 commented Aug 7, 2026

Copy link
Copy Markdown

Pull request

Changes description

  • Implements tmg changes
    • exploratory

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@wangben718

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@wangben718
wangben718 marked this pull request as draft August 7, 2026 22:23
@wangben718
wangben718 marked this pull request as ready for review August 7, 2026 22:24
@wangben718
wangben718 marked this pull request as draft August 10, 2026 06:10
Base automatically changed from upgrade_rstudio to dev August 10, 2026 12:19
@averissimo

Copy link
Copy Markdown
Contributor

Looking good, but I have 2 asks:

  • Can you please keep changes to exploratory/app.R file only and remove all renv.lock and such 🙏
  • Add some information on the text of the PR on the changes or some extra information needed.

They seem to be fine (some of them identical of what we already have in dev branch), but we should separate app.R PRs from dependencies changes.

See my PR, as it only touches app.R files, this should be similar with only 1 file: exploratory/app.R

image

@averissimo
averissimo self-requested a review August 10, 2026 14:39
@averissimo averissimo self-assigned this Aug 10, 2026
Signed-off-by: Bingjun(Benjamin) Wang <85646030+wangben718@users.noreply.github.com>
@wangben718

wangben718 commented Aug 10, 2026

Copy link
Copy Markdown
Author

deployment check failed due to this issue: insightsengineering/teal.modules.general#1011

@wangben718

Copy link
Copy Markdown
Author

Implement workaround by changing the default dataset name (ADLB -> ADLB_OUT) to avoid the default foreign key applied.

@averissimo

averissimo commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Please mark this as ready for review once I can take a look at it.

The issue has been corrected teal.picks and is now available in main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants