Open
Conversation
Drop 3.6 and 3.7 support. Update CI with coverage for all supported versions, including those that are EOL (3.8, 3.9), and near EOL (3.10). Signed-off-by: JP Hutchins <jp@intercreate.io>
a58d6a2 to
1f291ea
Compare
There was a problem hiding this comment.
Pull request overview
Updates the imgtool packaging metadata and CI to reflect dropping Python 3.6/3.7 support and to exercise the test suite across a broader set of supported Python runtimes.
Changes:
- Bump
python_requiresforimgtoolto>=3.8. - Replace Python 3.10+ union-type syntax in
isinstance()with a tuple form compatible with Python 3.8/3.9. - Expand the GitHub Actions test matrix to run across multiple CPython and PyPy versions (and update referenced action major versions).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
scripts/setup.py |
Raises minimum supported Python version for the package to 3.8+. |
scripts/imgtool/keys/general.py |
Avoids X | Y union syntax so the code runs on Python 3.8/3.9. |
.github/workflows/imgtool.yaml |
Expands CI matrix to cover multiple CPython/PyPy versions and updates action references. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop 3.6 and 3.7 support. Update CI with coverage for all supported versions, including those that are EOL (3.8, 3.9), and near EOL (3.10).
Wrote a script to test locally: