Feature/double by petersteneteg · Pull Request #281 · inviwo/modules

petersteneteg · 2026-04-16T07:27:29Z

No description provided.

github-actions · 2026-04-16T09:17:24Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format (v19.1.1) reports: 1 file(s) not formatted

molvis/molvisbase/src/algorithm/boundingbox.cpp

clang-tidy (v19.1.1) reports: 3 concern(s)

misc/nanovgpy/src/nanovgpymodule.cpp:30:10: error: [clang-diagnostic-error]

'inviwo/nanovgpy/nanovgpymodule.h' file not found
```
   30 | #include <inviwo/nanovgpy/nanovgpymodule.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
molvis/molvisbase/src/algorithm/boundingbox.cpp:30:10: error: [clang-diagnostic-error]

'inviwo/molvisbase/algorithm/boundingbox.h' file not found
```
   30 | #include <inviwo/molvisbase/algorithm/boundingbox.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

molvis/molvisbase/src/algorithm/boundingbox.cpp:44:22: warning: [misc-use-internal-linkage]

function 'calcBoundingBox' can be made static or moved into an anonymous namespace to enforce internal linkage

   44 | std::optional<dmat4> calcBoundingBox(const MolecularStructure& structure) {
      |                      ^              
      |                                     static

Have any feedback or feature suggestions? Share it here.

github-actions

Cpp-linter Review

Used clang-tidy v19.1.1

Click here for the full clang-tidy patch

diff --git a/molvis/molvisbase/src/algorithm/boundingbox.cpp b/molvis/molvisbase/src/algorithm/boundingbox.cpp
index 6cbb7d2..6724be6 100644
--- a/molvis/molvisbase/src/algorithm/boundingbox.cpp
+++ b/molvis/molvisbase/src/algorithm/boundingbox.cpp
@@ -42 +42 @@ namespace molvis {
-dmat4 boundingBox(const MolecularStructure& structure) {
+dmat4 boundingBoxstatic(const MolecularStructure& structure) {
@@ -71 +71 @@ template <typename const_iterator>
-dmat4 boundingBox(const_iterator begin, const_iterator end) {
+dmat4 boundingBoxstatic(const_iterator begin, const_iterator end) {
@@ -74,2 +74,2 @@ dmat4 boundingBox(const_iterator begin, const_iterator end) {
-    dvec3 worldMin(std::numeric_limits<float>::max());
-    dvec3 worldMax(std::numeric_limits<float>::lowest());
+    dvec3 worldMinstatic(std::numeric_limits<float>::max());
+    dvec3 worldMaxstatic(std::numeric_limits<float>::lowest());
@@ -101 +101 @@ dmat4 boundingBox(const_iterator begin, const_iterator end) {
-std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureInport& structure) {
+std::function<std::optional<dmat4>()> boundingBoxstatic(const MolecularStructureInport& structure) {
@@ -111 +111,2 @@ std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureInport
-std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureMultiInport& structures) {
+std::function<std::optional<dmat4>()> boundingBoxstatic(
+    const MolecularStructureMultiInport& structures) {
@@ -121 +122 @@ std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureMultiI
-std::function<std::optional<dmat4>()> boundingBox(
+std::function<std::optional<dmat4>()> boundingBoxstatic(
@@ -132 +133,2 @@ std::function<std::optional<dmat4>()> boundingBox(
-std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureOutport& structure) {
+std::function<std::optional<dmat4>()> boundingBoxstatic(
+    const MolecularStructureOutport& structure) {

Have any feedback or feature suggestions? Share it here.

outdated suggestion

github-actions

Cpp-linter Review

Used clang-tidy v19.1.1

Click here for the full clang-tidy patch

diff --git a/molvis/molvisbase/src/algorithm/boundingbox.cpp b/molvis/molvisbase/src/algorithm/boundingbox.cpp
index 6cbb7d2..6724be6 100644
--- a/molvis/molvisbase/src/algorithm/boundingbox.cpp
+++ b/molvis/molvisbase/src/algorithm/boundingbox.cpp
@@ -42 +42 @@ namespace molvis {
-dmat4 boundingBox(const MolecularStructure& structure) {
+dmat4 boundingBoxstatic(const MolecularStructure& structure) {
@@ -71 +71 @@ template <typename const_iterator>
-dmat4 boundingBox(const_iterator begin, const_iterator end) {
+dmat4 boundingBoxstatic(const_iterator begin, const_iterator end) {
@@ -74,2 +74,2 @@ dmat4 boundingBox(const_iterator begin, const_iterator end) {
-    dvec3 worldMin(std::numeric_limits<float>::max());
-    dvec3 worldMax(std::numeric_limits<float>::lowest());
+    dvec3 worldMinstatic(std::numeric_limits<float>::max());
+    dvec3 worldMaxstatic(std::numeric_limits<float>::lowest());
@@ -101 +101 @@ dmat4 boundingBox(const_iterator begin, const_iterator end) {
-std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureInport& structure) {
+std::function<std::optional<dmat4>()> boundingBoxstatic(const MolecularStructureInport& structure) {
@@ -111 +111,2 @@ std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureInport
-std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureMultiInport& structures) {
+std::function<std::optional<dmat4>()> boundingBoxstatic(
+    const MolecularStructureMultiInport& structures) {
@@ -121 +122 @@ std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureMultiI
-std::function<std::optional<dmat4>()> boundingBox(
+std::function<std::optional<dmat4>()> boundingBoxstatic(
@@ -132 +133,2 @@ std::function<std::optional<dmat4>()> boundingBox(
-std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureOutport& structure) {
+std::function<std::optional<dmat4>()> boundingBoxstatic(
+    const MolecularStructureOutport& structure) {

Have any feedback or feature suggestions? Share it here.

outdated suggestion

github-actions

Cpp-linter Review

Used clang-tidy v19.1.1

Click here for the full clang-tidy patch

diff --git a/molvis/molvisbase/src/algorithm/boundingbox.cpp b/molvis/molvisbase/src/algorithm/boundingbox.cpp
index 6cbb7d2..6724be6 100644
--- a/molvis/molvisbase/src/algorithm/boundingbox.cpp
+++ b/molvis/molvisbase/src/algorithm/boundingbox.cpp
@@ -42 +42 @@ namespace molvis {
-dmat4 boundingBox(const MolecularStructure& structure) {
+dmat4 boundingBoxstatic(const MolecularStructure& structure) {
@@ -71 +71 @@ template <typename const_iterator>
-dmat4 boundingBox(const_iterator begin, const_iterator end) {
+dmat4 boundingBoxstatic(const_iterator begin, const_iterator end) {
@@ -74,2 +74,2 @@ dmat4 boundingBox(const_iterator begin, const_iterator end) {
-    dvec3 worldMin(std::numeric_limits<float>::max());
-    dvec3 worldMax(std::numeric_limits<float>::lowest());
+    dvec3 worldMinstatic(std::numeric_limits<float>::max());
+    dvec3 worldMaxstatic(std::numeric_limits<float>::lowest());
@@ -101 +101 @@ dmat4 boundingBox(const_iterator begin, const_iterator end) {
-std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureInport& structure) {
+std::function<std::optional<dmat4>()> boundingBoxstatic(const MolecularStructureInport& structure) {
@@ -111 +111,2 @@ std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureInport
-std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureMultiInport& structures) {
+std::function<std::optional<dmat4>()> boundingBoxstatic(
+    const MolecularStructureMultiInport& structures) {
@@ -121 +122 @@ std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureMultiI
-std::function<std::optional<dmat4>()> boundingBox(
+std::function<std::optional<dmat4>()> boundingBoxstatic(
@@ -132 +133,2 @@ std::function<std::optional<dmat4>()> boundingBox(
-std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureOutport& structure) {
+std::function<std::optional<dmat4>()> boundingBoxstatic(
+    const MolecularStructureOutport& structure) {

Have any feedback or feature suggestions? Share it here.

outdated suggestion

github-actions

Cpp-linter Review

Used clang-tidy v19.1.1

Click here for the full clang-tidy patch

diff --git a/molvis/molvisbase/src/algorithm/boundingbox.cpp b/molvis/molvisbase/src/algorithm/boundingbox.cpp
index 6cbb7d2..6724be6 100644
--- a/molvis/molvisbase/src/algorithm/boundingbox.cpp
+++ b/molvis/molvisbase/src/algorithm/boundingbox.cpp
@@ -42 +42 @@ namespace molvis {
-dmat4 boundingBox(const MolecularStructure& structure) {
+dmat4 boundingBoxstatic(const MolecularStructure& structure) {
@@ -71 +71 @@ template <typename const_iterator>
-dmat4 boundingBox(const_iterator begin, const_iterator end) {
+dmat4 boundingBoxstatic(const_iterator begin, const_iterator end) {
@@ -74,2 +74,2 @@ dmat4 boundingBox(const_iterator begin, const_iterator end) {
-    dvec3 worldMin(std::numeric_limits<float>::max());
-    dvec3 worldMax(std::numeric_limits<float>::lowest());
+    dvec3 worldMinstatic(std::numeric_limits<float>::max());
+    dvec3 worldMaxstatic(std::numeric_limits<float>::lowest());
@@ -101 +101 @@ dmat4 boundingBox(const_iterator begin, const_iterator end) {
-std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureInport& structure) {
+std::function<std::optional<dmat4>()> boundingBoxstatic(const MolecularStructureInport& structure) {
@@ -111 +111,2 @@ std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureInport
-std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureMultiInport& structures) {
+std::function<std::optional<dmat4>()> boundingBoxstatic(
+    const MolecularStructureMultiInport& structures) {
@@ -121 +122 @@ std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureMultiI
-std::function<std::optional<dmat4>()> boundingBox(
+std::function<std::optional<dmat4>()> boundingBoxstatic(
@@ -132 +133,2 @@ std::function<std::optional<dmat4>()> boundingBox(
-std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureOutport& structure) {
+std::function<std::optional<dmat4>()> boundingBoxstatic(
+    const MolecularStructureOutport& structure) {

Have any feedback or feature suggestions? Share it here.

github-actions · 2026-04-21T11:41:10Z

 namespace molvis {

-mat4 boundingBox(const MolecularStructure& structure) {
+dmat4 boundingBox(const MolecularStructure& structure) {


clang-tidy diagnostics

function 'boundingBox' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]

Suggested change

dmat4 boundingBox(const MolecularStructure& structure) {

dmat4 boundingBoxstatic(const MolecularStructure& structure) {

github-actions · 2026-04-21T11:41:11Z

 template <typename const_iterator>
-mat4 boundingBox(const_iterator begin, const_iterator end) {
-    if (begin == end) return mat4(0.0f);
+dmat4 boundingBox(const_iterator begin, const_iterator end) {


clang-tidy diagnostics

function 'boundingBox' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]

Suggested change

dmat4 boundingBox(const_iterator begin, const_iterator end) {

dmat4 boundingBoxstatic(const_iterator begin, const_iterator end) {

github-actions · 2026-04-21T11:41:11Z

+    dvec3 worldMin(std::numeric_limits<float>::max());
+    dvec3 worldMax(std::numeric_limits<float>::lowest());


clang-tidy diagnostics

function 'worldMin' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]

function 'worldMax' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]

Suggested change

dvec3 worldMin(std::numeric_limits<float>::max());

dvec3 worldMax(std::numeric_limits<float>::lowest());

dvec3 worldMinstatic(std::numeric_limits<float>::max());

dvec3 worldMaxstatic(std::numeric_limits<float>::lowest());

github-actions · 2026-04-21T11:41:11Z

 }

-std::function<std::optional<mat4>()> boundingBox(const MolecularStructureInport& structure) {
+std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureInport& structure) {


clang-tidy diagnostics

function 'boundingBox' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]

Suggested change

std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureInport& structure) {

std::function<std::optional<dmat4>()> boundingBoxstatic(const MolecularStructureInport& structure) {

github-actions · 2026-04-21T11:41:11Z

 }

-std::function<std::optional<mat4>()> boundingBox(const MolecularStructureMultiInport& structures) {
+std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureMultiInport& structures) {


clang-tidy diagnostics

function 'boundingBox' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]

Suggested change

std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureMultiInport& structures) {

std::function<std::optional<dmat4>()> boundingBoxstatic(

const MolecularStructureMultiInport& structures) {

github-actions · 2026-04-21T11:41:11Z

 }

-std::function<std::optional<mat4>()> boundingBox(
+std::function<std::optional<dmat4>()> boundingBox(


clang-tidy diagnostics

function 'boundingBox' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]

Suggested change

std::function<std::optional<dmat4>()> boundingBox(

std::function<std::optional<dmat4>()> boundingBoxstatic(

github-actions · 2026-04-21T11:41:11Z

 }

-std::function<std::optional<mat4>()> boundingBox(const MolecularStructureOutport& structure) {
+std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureOutport& structure) {


clang-tidy diagnostics

function 'boundingBox' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]

Suggested change

std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureOutport& structure) {

std::function<std::optional<dmat4>()> boundingBoxstatic(

const MolecularStructureOutport& structure) {

Error: vcpkg_installed/x64-linux-dynamic/include/nanovg_gl.h:451:20: error: no match for ‘operator!=’ (operand types are ‘gl::GLint’ {aka ‘int’} and ‘const gl::GLboolean’ {aka ‘const glbinding::Boolean8’}) 451 | if (status != GL_TRUE) { | ~~~~~~ ^~ ~~~~~~~ | | | | | const gl::GLboolean {aka const glbinding::Boolean8} | gl::GLint {aka int}

outdated suggestion

github-actions

Cpp-linter Review

Used clang-tidy v19.1.1

Click here for the full clang-tidy patch

diff --git a/molvis/molvisbase/src/algorithm/boundingbox.cpp b/molvis/molvisbase/src/algorithm/boundingbox.cpp
index 8e3d29e..11476ea 100644
--- a/molvis/molvisbase/src/algorithm/boundingbox.cpp
+++ b/molvis/molvisbase/src/algorithm/boundingbox.cpp
@@ -44 +44 @@ namespace molvis {
-std::optional<dmat4> calcBoundingBox(const MolecularStructure& structure) {
+std::optional<dmat4> calcBoundingBoxstatic(const MolecularStructure& structure) {

Have any feedback or feature suggestions? Share it here.

github-actions · 2026-04-23T20:53:16Z

@@ -29,6 +29,8 @@

 #include <inviwo/nanovgpy/nanovgpymodule.h>


clang-tidy diagnostic

misc/nanovgpy/src/nanovgpymodule.cpp:30:10: error: [clang-diagnostic-error]

'inviwo/nanovgpy/nanovgpymodule.h' file not found

30 | #include <inviwo/nanovgpy/nanovgpymodule.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

github-actions · 2026-04-23T20:53:16Z

 namespace molvis {

-mat4 boundingBox(const MolecularStructure& structure) {
+std::optional<dmat4> calcBoundingBox(const MolecularStructure& structure) {


clang-tidy diagnostics

function 'calcBoundingBox' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]

Suggested change

std::optional<dmat4> calcBoundingBox(const MolecularStructure& structure) {

std::optional<dmat4> calcBoundingBoxstatic(const MolecularStructure& structure) {

github-actions · 2026-04-23T20:53:17Z

@@ -30,16 +30,18 @@
 #include <inviwo/molvisbase/algorithm/boundingbox.h>


clang-tidy diagnostic

molvis/molvisbase/src/algorithm/boundingbox.cpp:30:10: error: [clang-diagnostic-error]

'inviwo/molvisbase/algorithm/boundingbox.h' file not found

30 | #include <inviwo/molvisbase/algorithm/boundingbox.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

outdated suggestion

github-actions

Cpp-linter Review

Used clang-tidy v19.1.1

Click here for the full clang-tidy patch

diff --git a/molvis/molvisbase/src/algorithm/boundingbox.cpp b/molvis/molvisbase/src/algorithm/boundingbox.cpp
index 8e3d29e..11476ea 100644
--- a/molvis/molvisbase/src/algorithm/boundingbox.cpp
+++ b/molvis/molvisbase/src/algorithm/boundingbox.cpp
@@ -44 +44 @@ namespace molvis {
-std::optional<dmat4> calcBoundingBox(const MolecularStructure& structure) {
+std::optional<dmat4> calcBoundingBoxstatic(const MolecularStructure& structure) {

Have any feedback or feature suggestions? Share it here.

github-actions · 2026-04-24T08:12:38Z

@@ -29,6 +29,8 @@

 #include <inviwo/nanovgpy/nanovgpymodule.h>


clang-tidy diagnostic

misc/nanovgpy/src/nanovgpymodule.cpp:30:10: error: [clang-diagnostic-error]

'inviwo/nanovgpy/nanovgpymodule.h' file not found

30 | #include <inviwo/nanovgpy/nanovgpymodule.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

github-actions · 2026-04-24T08:12:38Z

 namespace molvis {

-mat4 boundingBox(const MolecularStructure& structure) {
+std::optional<dmat4> calcBoundingBox(const MolecularStructure& structure) {


clang-tidy diagnostics

function 'calcBoundingBox' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]

Suggested change

std::optional<dmat4> calcBoundingBox(const MolecularStructure& structure) {

std::optional<dmat4> calcBoundingBoxstatic(const MolecularStructure& structure) {

github-actions · 2026-04-24T08:12:38Z

@@ -30,16 +30,18 @@
 #include <inviwo/molvisbase/algorithm/boundingbox.h>


clang-tidy diagnostic

molvis/molvisbase/src/algorithm/boundingbox.cpp:30:10: error: [clang-diagnostic-error]

'inviwo/molvisbase/algorithm/boundingbox.h' file not found

30 | #include <inviwo/molvisbase/algorithm/boundingbox.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

outdated suggestion

github-actions

Cpp-linter Review

Used clang-tidy v19.1.1

Click here for the full clang-tidy patch

diff --git a/molvis/molvisbase/src/algorithm/boundingbox.cpp b/molvis/molvisbase/src/algorithm/boundingbox.cpp
index 8e3d29e..11476ea 100644
--- a/molvis/molvisbase/src/algorithm/boundingbox.cpp
+++ b/molvis/molvisbase/src/algorithm/boundingbox.cpp
@@ -44 +44 @@ namespace molvis {
-std::optional<dmat4> calcBoundingBox(const MolecularStructure& structure) {
+std::optional<dmat4> calcBoundingBoxstatic(const MolecularStructure& structure) {

Have any feedback or feature suggestions? Share it here.

github-actions · 2026-04-24T14:48:50Z

@@ -29,6 +29,8 @@

 #include <inviwo/nanovgpy/nanovgpymodule.h>


clang-tidy diagnostic

misc/nanovgpy/src/nanovgpymodule.cpp:30:10: error: [clang-diagnostic-error]

'inviwo/nanovgpy/nanovgpymodule.h' file not found

30 | #include <inviwo/nanovgpy/nanovgpymodule.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

github-actions · 2026-04-24T14:48:50Z

 namespace molvis {

-mat4 boundingBox(const MolecularStructure& structure) {
+std::optional<dmat4> calcBoundingBox(const MolecularStructure& structure) {


clang-tidy diagnostics

function 'calcBoundingBox' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]

Suggested change

std::optional<dmat4> calcBoundingBox(const MolecularStructure& structure) {

std::optional<dmat4> calcBoundingBoxstatic(const MolecularStructure& structure) {

github-actions · 2026-04-24T14:48:50Z

@@ -30,16 +30,18 @@
 #include <inviwo/molvisbase/algorithm/boundingbox.h>


clang-tidy diagnostic

molvis/molvisbase/src/algorithm/boundingbox.cpp:30:10: error: [clang-diagnostic-error]

'inviwo/molvisbase/algorithm/boundingbox.h' file not found

30 | #include <inviwo/molvisbase/algorithm/boundingbox.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

outdated suggestion

github-actions

Cpp-linter Review

Used clang-tidy v19.1.1

Click here for the full clang-tidy patch

diff --git a/molvis/molvisbase/src/algorithm/boundingbox.cpp b/molvis/molvisbase/src/algorithm/boundingbox.cpp
index 8e3d29e..11476ea 100644
--- a/molvis/molvisbase/src/algorithm/boundingbox.cpp
+++ b/molvis/molvisbase/src/algorithm/boundingbox.cpp
@@ -44 +44 @@ namespace molvis {
-std::optional<dmat4> calcBoundingBox(const MolecularStructure& structure) {
+std::optional<dmat4> calcBoundingBoxstatic(const MolecularStructure& structure) {

Have any feedback or feature suggestions? Share it here.

github-actions · 2026-04-24T18:29:44Z

@@ -29,6 +29,8 @@

 #include <inviwo/nanovgpy/nanovgpymodule.h>


clang-tidy diagnostic

misc/nanovgpy/src/nanovgpymodule.cpp:30:10: error: [clang-diagnostic-error]

'inviwo/nanovgpy/nanovgpymodule.h' file not found

30 | #include <inviwo/nanovgpy/nanovgpymodule.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

github-actions · 2026-04-24T18:29:44Z

 namespace molvis {

-mat4 boundingBox(const MolecularStructure& structure) {
+std::optional<dmat4> calcBoundingBox(const MolecularStructure& structure) {


clang-tidy diagnostics

function 'calcBoundingBox' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]

Suggested change

std::optional<dmat4> calcBoundingBox(const MolecularStructure& structure) {

std::optional<dmat4> calcBoundingBoxstatic(const MolecularStructure& structure) {

github-actions · 2026-04-24T18:29:44Z

@@ -30,16 +30,18 @@
 #include <inviwo/molvisbase/algorithm/boundingbox.h>


clang-tidy diagnostic

molvis/molvisbase/src/algorithm/boundingbox.cpp:30:10: error: [clang-diagnostic-error]

'inviwo/molvisbase/algorithm/boundingbox.h' file not found

30 | #include <inviwo/molvisbase/algorithm/boundingbox.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

…d version

outdated suggestion

github-actions

Cpp-linter Review

Used clang-tidy v19.1.1

Click here for the full clang-tidy patch

diff --git a/molvis/molvisbase/src/algorithm/boundingbox.cpp b/molvis/molvisbase/src/algorithm/boundingbox.cpp
index 8e3d29e..11476ea 100644
--- a/molvis/molvisbase/src/algorithm/boundingbox.cpp
+++ b/molvis/molvisbase/src/algorithm/boundingbox.cpp
@@ -44 +44 @@ namespace molvis {
-std::optional<dmat4> calcBoundingBox(const MolecularStructure& structure) {
+std::optional<dmat4> calcBoundingBoxstatic(const MolecularStructure& structure) {

Have any feedback or feature suggestions? Share it here.

github-actions · 2026-04-25T11:04:07Z

@@ -29,6 +29,8 @@

 #include <inviwo/nanovgpy/nanovgpymodule.h>


clang-tidy diagnostic

misc/nanovgpy/src/nanovgpymodule.cpp:30:10: error: [clang-diagnostic-error]

'inviwo/nanovgpy/nanovgpymodule.h' file not found

30 | #include <inviwo/nanovgpy/nanovgpymodule.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

github-actions · 2026-04-25T11:04:07Z

 namespace molvis {

-mat4 boundingBox(const MolecularStructure& structure) {
+std::optional<dmat4> calcBoundingBox(const MolecularStructure& structure) {


clang-tidy diagnostics

function 'calcBoundingBox' can be made static or moved into an anonymous namespace to enforce internal linkage [misc-use-internal-linkage]

Suggested change

std::optional<dmat4> calcBoundingBox(const MolecularStructure& structure) {

std::optional<dmat4> calcBoundingBoxstatic(const MolecularStructure& structure) {

github-actions · 2026-04-25T11:04:07Z

@@ -30,16 +30,18 @@
 #include <inviwo/molvisbase/algorithm/boundingbox.h>


clang-tidy diagnostic

molvis/molvisbase/src/algorithm/boundingbox.cpp:30:10: error: [clang-diagnostic-error]

'inviwo/molvisbase/algorithm/boundingbox.h' file not found

30 | #include <inviwo/molvisbase/algorithm/boundingbox.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

bot

petersteneteg added 3 commits April 16, 2026 09:26

MolVis: fixes for core changes (float -> double)

5e41389

TensorVis: fixes for core changes (float -> double)

bd68ab4

Vtk: update to core change

fe93004

martinfalk approved these changes Apr 16, 2026

View reviewed changes

github-actions Bot previously requested changes Apr 16, 2026

View reviewed changes

martinfalk added 2 commits April 20, 2026 09:44

MolVis,Misc: fixes for core changes (float -> double)

c2388df

Testing: updated reference images

47942ab

github-actions Bot previously requested changes Apr 20, 2026

View reviewed changes

C3D: fixes for core changes (float -> double)

62f6fd9

github-actions Bot previously requested changes Apr 20, 2026

View reviewed changes

petersteneteg added 4 commits April 21, 2026 11:12

NanoVG: fix

12c6618

VTK: float -> double fix

17f98e3

TensorVis: glbinding fix

b039893

MolVis: boundingBox fixes

055a07a

martinfalk approved these changes Apr 21, 2026

View reviewed changes

github-actions Bot previously requested changes Apr 21, 2026

View reviewed changes

petersteneteg added 4 commits April 23, 2026 13:28

NanoVG: update to core changes

638a330

NanoVGPy: gil fix

2c3cd24

vcpkg: nanovg overlay

8646a9c

github-actions Bot previously requested changes Apr 23, 2026

View reviewed changes

MolVis: python fixes

f7b237a

github-actions Bot previously requested changes Apr 24, 2026

View reviewed changes

MolvisPy: fix

a6d507c

martinfalk approved these changes Apr 24, 2026

View reviewed changes

github-actions Bot previously requested changes Apr 24, 2026

View reviewed changes

Vasp: regression update

1889e6f

github-actions Bot previously requested changes Apr 24, 2026

View reviewed changes

GHA: disable pythontools on linux, scipy does not work in the package…

7714958

…d version

github-actions Bot previously requested changes Apr 25, 2026

View reviewed changes

petersteneteg merged commit fb20ec4 into master Apr 27, 2026
18 checks passed

petersteneteg deleted the feature/double branch April 27, 2026 06:27

github-actions Bot pushed a commit to inviwo/regression that referenced this pull request Apr 27, 2026

Remove regression reports for MERGED PR inviwo/modules#281

f3a71ee

	dmat4 boundingBox(const MolecularStructure& structure) {
	dmat4 boundingBoxstatic(const MolecularStructure& structure) {

	dmat4 boundingBox(const_iterator begin, const_iterator end) {
	dmat4 boundingBoxstatic(const_iterator begin, const_iterator end) {

		dvec3 worldMin(std::numeric_limits<float>::max());
		dvec3 worldMax(std::numeric_limits<float>::lowest());

	std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureInport& structure) {
	std::function<std::optional<dmat4>()> boundingBoxstatic(const MolecularStructureInport& structure) {

	std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureMultiInport& structures) {
	std::function<std::optional<dmat4>()> boundingBoxstatic(
	const MolecularStructureMultiInport& structures) {

	std::function<std::optional<dmat4>()> boundingBox(const MolecularStructureOutport& structure) {
	std::function<std::optional<dmat4>()> boundingBoxstatic(
	const MolecularStructureOutport& structure) {

		@@ -29,6 +29,8 @@

		#include <inviwo/nanovgpy/nanovgpymodule.h>

	std::optional<dmat4> calcBoundingBox(const MolecularStructure& structure) {
	std::optional<dmat4> calcBoundingBoxstatic(const MolecularStructure& structure) {

		@@ -30,16 +30,18 @@
		#include <inviwo/molvisbase/algorithm/boundingbox.h>

Conversation

petersteneteg commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Cpp-Linter Report ⚠️

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-tidy v19.1.1

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-tidy v19.1.1

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-tidy v19.1.1

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-tidy v19.1.1

Uh oh!

github-actions Bot Apr 21, 2026

Choose a reason for hiding this comment

clang-tidy diagnostics

Uh oh!

github-actions Bot Apr 21, 2026

Choose a reason for hiding this comment

clang-tidy diagnostics

Uh oh!

github-actions Bot Apr 21, 2026

Choose a reason for hiding this comment

clang-tidy diagnostics

Uh oh!

github-actions Bot Apr 21, 2026

Choose a reason for hiding this comment

clang-tidy diagnostics

Uh oh!

github-actions Bot Apr 21, 2026

Choose a reason for hiding this comment

clang-tidy diagnostics

Uh oh!

github-actions Bot Apr 21, 2026

Choose a reason for hiding this comment

clang-tidy diagnostics

Uh oh!

github-actions Bot Apr 21, 2026

Choose a reason for hiding this comment

clang-tidy diagnostics

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Cpp-linter Review

Used clang-tidy v19.1.1

github-actions Bot commented Apr 16, 2026 •

edited

Loading