Fr approvals docs#477
Merged
Merged
Conversation
Adds the missing POST /sign endpoint, fixes POST /agreement (data only, no signature field), fixes POST /confirm (200 + status, not 204), corrects the 4 MB identity upload limit, and documents identity verification as required on both signing paths. Adds a step-by-step signing section to the registration guide covering both in-app and pre-signed PDF flows. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Documents the link_url/wizard approach alongside the entry API, matching the VeriFACTU guide structure. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Gov-FR onboarding approval documentation and OpenAPI spec to reflect a two-path agreement signing flow (in-app signature stamping vs uploading a pre-signed PDF), and to surface the post-confirmation approval status to API consumers.
Changes:
- Refines
/agreement(GET/POST) semantics and request schemas to focus on pre-signed PDF uploads. - Adds
POST /signfor in-app signing and updatesPOST /confirmto return a status payload. - Extends FR PA registration guide + API reference navigation and pages to document the new flow.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| openapi/apps/gov-fr_v1.yaml | Updates agreement/identity/confirm docs, adds /sign, and introduces/adjusts related schemas and response payloads. |
| guides/fr-pa-registration.mdx | Documents the agreement signing step, wizard flow, and the two API-driven signing paths. |
| docs.json | Adds the new Gov-FR /sign API reference page to the docs nav. |
| api-ref/apps/gov-fr/sign.mdx | New API reference page for POST /sign. |
| api-ref/apps/gov-fr/identity-upload.mdx | Updates identity upload reference to reflect it’s required for both signing paths. |
| api-ref/apps/gov-fr/confirm.mdx | Updates confirm reference to reflect status-returning confirmation. |
| api-ref/apps/gov-fr/agreement-upload.mdx | Renames/reframes agreement upload as pre-signed upload (needs a small completeness fix). |
| api-ref/apps/gov-fr/agreement-fetch.mdx | Updates agreement fetch reference to reflect signed-vs-unsigned behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
methodofaction
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.