[feature/BLAZ-2484] to dev

[abausac]

Add Terraform plan tests for startleft

[smaneroiriusrisk]

The VALIDATION UC1 and UC5 described in the task are not covered by the TestOTMControllerIaC.test_controller_no_iac_file or TestOTMControllerIaC.test_controller_no_mapping_file as the error message and the error type does not match. The main reason is the decorator @check_mime_type is not working for the test when you send a file as None. If we remove the decorator from the controller the test would still working.

The PROCESSOR UC3 ask for the hcp-tfplan/opt-792 uses cases. You refer to the TestOTMControllerIaC."test_mapping_files_validations_success" implementations, but I miss the use case which send both default_mapping_file and mapping_file. We have to assure this case is forbidden. Is this test case implemented?

[abausac]

The VALIDATION UC1 and UC5 described in the task are not covered by the TestOTMControllerIaC.test_controller_no_iac_file or TestOTMControllerIaC.test_controller_no_mapping_file as the error message and the error type does not match. The main reason is the decorator @check_mime_type is not working for the test when you send a file as None. If we remove the decorator from the controller the test would still working.

The PROCESSOR UC3 ask for the hcp-tfplan/opt-792 uses cases. You refer to the TestOTMControllerIaC."test_mapping_files_validations_success" implementations, but I miss the use case which send both default_mapping_file and mapping_file. We have to assure this case is forbidden. Is this test case implemented?

About the UC1 and UC5, the API has a different response (the expected as ticket described) than test response.
The error message check done in the test for UC1 and UC5 (iac_file and mapping_file as None) was removed, as it makes no sense to check a non possible message.

In the case of the PROCESSOR UC3, the code already exists (done for Cloudformation, in BLAZ-2411), in:

startleft/tests/integration/api/controllers/iac/test_otm_controller_iac.py

Line 258 in a1fb2a1

def test_mapping_files_validations_errors(self, files, title, detail, error_message):