Fix crash concurrent ftx UI postevent#59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR fixes app crashing after a while.
Root cause: background threads (the RPC poller, the animation ticker,
and every Lua tab worker) called ftxui::App::PostEvent() concurrently.
In FTXUI 7, PostEvent pushes onto an unlocked std::deque
(MultiReceiverBuffer::Push) and mutates animation state with no lock,
so it is loop-thread-only. Concurrent producers raced the loop's
consumer and corrupted the queue
This is a regression from the v6->v7 upgrade, where ScreenInteractive::PostEvent
used to be mutex-protected.