feat(desktop): add fish shell support for Claude Code env export - #8451
Open
dfjay wants to merge 1 commit into
Open
feat(desktop): add fish shell support for Claude Code env export#8451dfjay wants to merge 1 commit into
dfjay wants to merge 1 commit into
Conversation
dfjay
force-pushed
the
feat/claude-code-fish-shell-env
branch
from
July 21, 2026 08:27
ee5e12a to
0a4d3ca
Compare
fish never sources ~/.zshenv and doesn't understand `export`, so the Claude Code integration silently did nothing for fish users. Detect fish via $SHELL and write `set -gx` vars to conf.d/jan-claude-code.fish; Reset now strips both syntaxes. Assisted-by: Claude Code
dfjay
force-pushed
the
feat/claude-code-fish-shell-env
branch
from
July 21, 2026 08:40
0a4d3ca to
9dafbcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
Jan's Claude Code integration wrote the
ANTHROPIC_*env vars to~/.zshenvwithexportsyntax for any shell that wasn't bash. fish never sources~/.zshenvand doesn't understandexport, so fish users enabling the integration got no effect at all — it silently did nothing.$SHELLand write to~/.config/fish/conf.d/jan-claude-code.fishusing fish syntax (set -gx). conf.d is auto-sourced beforeconfig.fishon every fish session, matching the "always sourced" behaviour Jan relies on for zsh's~/.zshenv.exportandset -gxANTHROPIC_lines, so switching shells or resetting works.env_file_for_shell/format_env_line/is_jan_env_linewith unit tests.Fixes Issues
Self Checklist