fix: handle asynchronous minification and HTML emission errors - #1895
Open
OskarEichler wants to merge 1 commit into
Open
fix: handle asynchronous minification and HTML emission errors#1895OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
minify: false). The synchronous catch currently misses rejections fromhtml-minifier-terser.postProcessHtmlremains Promise-returning; making it async also removes redundant Promise wrappers. Successful HTML output, plugin options, and supported Node versions are unchanged. No breaking API changes or dependency changes.Verification
git diff --checkpass.tscreports existing TS2802 on the unrelated Set spread ingetAssetFiles; reproduced against unmodified upstream using the same compiler host.tsc --downlevelIterationpasses with this patch. No TypeScript configuration changes are included.