Skip to content

Handle float singular counts#240

Open
Mirochill wants to merge 1 commit into
jaraco:mainfrom
Mirochill:fix-232-float-count
Open

Handle float singular counts#240
Mirochill wants to merge 1 commit into
jaraco:mainfrom
Mirochill:fix-232-float-count

Conversation

@Mirochill

@Mirochill Mirochill commented May 18, 2026

Copy link
Copy Markdown

Summary

  • treat numeric counts equal to 1 (including 1.0) as singular in get_count()
  • preserve the existing bool behavior so True is not silently reclassified as a numeric singular count
  • add a focused regression case and changelog note

References

Validation

  • Not run locally
  • relying on the repository's GitHub Actions checks for remote validation

@Mirochill Mirochill marked this pull request as ready for review May 20, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get_count returns 2 when the float 1.0 is passed in, this leads to bad pluralizations if you have a float input

1 participant