Skip to content

Treat float 1.0 as a singular count #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gaoflow wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −2
Open

Treat float 1.0 as a singular count #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions inflect/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2671,13 +2671,19 @@ def get_count(self, count: Optional[Union[str, int]] = None) -> Union[str, int]:
count = self.persistent_count

if count is not None:
count_text = str(count)
count = (
1
if (
(str(count) in pl_count_one)
(
isinstance(count, Number)
and not isinstance(count, bool)
and count == 1
)
or (count_text in pl_count_one)
or (
self.classical_dict["zero"]
and str(count).lower() in pl_count_zero
and count_text.lower() in pl_count_zero
)
)
else 2
Expand Down
2 changes: 2 additions & 0 deletions tests/test_pwd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,7 @@ def test_pl(self):

for sing, num, plur in (
("cow", 1, "cow"),
("cow", 1.0, "cow"),
("cow", 2, "cows"),
("cow", "one", "cow"),
("cow", "each", "cow"),
Expand Down Expand Up @@ -534,6 +535,7 @@ def test_count(self):
p = inflect.engine()
for txt, num in (
(1, 1),
(1.0, 1),
(2, 2),
(0, 2),
(87, 2),
Expand Down