fix: present_participle('be') returns 'bing' instead of 'being'#252
Open
gaoflow wants to merge 1 commit into
Open
fix: present_participle('be') returns 'bing' instead of 'being'#252gaoflow wants to merge 1 commit into
gaoflow wants to merge 1 commit into
Conversation
The PRESENT_PARTICIPLE_REPLACEMENTS rule `([^e])e$` drops the trailing 'e' from any word ending in a non-e consonant + e. This incorrectly strips 'be' down to 'b', yielding 'bing'. Add an explicit guard for '^be$' ahead of that rule so 'be' passes through intact and produces 'being'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
present_participle('be')produces'bing'instead of'being'.The root cause is the catch-all rule
([^e])e$inPRESENT_PARTICIPLE_REPLACEMENTS, which drops the trailingefromany word ending in e. For a two-letter word like
bethat leaves onlyb, then+ ing = bing.The fix adds an explicit guard
^(be)$immediately before that rule(consistent with the existing guards for
are,were,had,hoe)so
bepasses through intact and producesbeing.Test plan
assert p.present_participle("be") == "being"added totest_prespart