MODULE.bazel: mark test/toolchain deps as dev_dependency - #67
Merged
Merged
Conversation
fuzztest + googletest are only consumed by snmalloc's own C++ tests. Marking them dev keeps them out of downstream resolution — fuzztest otherwise drags rules_go in, whose cgo.bzl references a CcInfo symbol removed in modern rules_cc and breaks any bzlmod consumer. The rules_rust toolchain extension is likewise dev-only — downstream workspaces pin their own toolchain and a transitive registration here would silently overlay it.
jayakasadev
force-pushed
the
bazel-dev-deps
branch
from
June 12, 2026 20:36
8ccc622 to
4194727
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Mark fuzztest + googletest + the rules_rust toolchain extension as
dev_dependency = TrueinMODULE.bazel. Dropregister_toolchains("@rust_toolchains//:all").Why
cgo.bzlreferences aCcInfosymbol removed in modern rules_cc — breaks any modern bzlmod project that uses snmalloc as a dep.register_toolchains: only needed for snmalloc's ownbazel test //snmalloc-rs/.... As a non-dev registration it would silently overlay a downstream consumer's own toolchain pin.Cost
Snmalloc's own Rust dev/CI loop now needs
--extra_toolchains=@rust_toolchains//:all(e.g. in.bazelrc) sinceregister_toolchainswas removed. Not added in this PR.Evidence
Diff is
MODULE.bazelonly.