Skip to content

fix(bazel): un-scope crate_universe extension so @crates resolves downstream #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jayakasadev merged 1 commit into from
Jun 16, 2026
Merged

fix(bazel): un-scope crate_universe extension so @crates resolves downstream #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,17 @@ use_repo(rust, "rust_toolchains")

# crate_universe entries for snmalloc-rs optional dependencies. Currently
# just flate2 (pulled by the `profiling` Cargo feature via `dep:flate2`
# for `HeapProfile::write_pprof_gz`). `dev_dependency = True` keeps these
# scoped to snmalloc's own dev/CI loop so downstream consumers depending
# on `@snmalloc//snmalloc-rs:snmalloc_rs_profiling` do not transitively
# pull crate_universe -- they're expected to register flate2 themselves
# via their own crate_universe extension and inject it through the
# `flate2` repo alias (see snmalloc-rs/BUILD.bazel).
# for `HeapProfile::write_pprof_gz`). Must NOT be `dev_dependency = True`:
# the matching BUILD label `@crates//:flate2` is referenced unconditionally
# by `snmalloc-rs/BUILD.bazel`'s `:snmalloc_rs_profiling` target, and Bazel
# skips dev_dependencies of non-root modules. With dev scoping on, any
# downstream consumer depending on `:snmalloc_rs_profiling` analyze-fails
# with `No repository visible as '@crates' from repository '@@snmalloc+'`.
# (The flate2-free `:snmalloc_rs_profile_compat` target remains available
# for consumers that do not need `write_pprof_gz`.)
crate = use_extension(
"@rules_rust//crate_universe:extension.bzl",
"crate",
dev_dependency = True,
)
crate.spec(
package = "flate2",
Expand Down