chore(desktop-e2e): add Playwright _electron E2E suite for the desktop app

[paustint]

Repurposes the unused jetstream-desktop-client-e2e scaffold (renamed to jetstream-desktop-e2e) into a real Electron-launching Playwright suite. Previously it only drove the renderer as a plain web page and never exercised the actual Electron shell.

• Launches the built main.js with an isolated --user-data-dir per test; auth is seeded by calling the same /desktop-app/auth/session + /verify endpoints the app itself uses, no browser/OS login UI driven
• Covers app launch, cross-origin window.open() -> shell.openExternal routing, authenticated boot, the Settings screen, a live Salesforce query round-trip, and first-pass adversarial coverage of the dataHistoryRequest/request() IPC surface (path traversal, host independence)
• Adds reusable ElectronApiClient/ElectronMainProcess fixtures to @jetstream/test/e2e-utils so a future security-fuzz suite can share them without rework
• Wires a new desktop-e2e CI job (Xvfb-wrapped, gated on the desktop projects being affected) — not yet added to the required e2e check pending a proven run
• Fixes global.setup.ts to grant the EXAMPLE_USER account's desktop entitlement: without it, initSession's MissingEntitlement redirect is silently followed by Playwright's request API, returning the login page's HTML where JSON was expected

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@​salesforce-ux/​design-system-2@​2.264.1
	next@​16.3.1
	@​tanstack/​react-store@​0.11.1
	esbuild@​0.28.2
	@​react-email/​ui@​6.9.2
	chrome-types@​0.1.439
	@​types/​chrome@​0.2.6
	vite@​8.2.1
	oauth4webapi@​3.8.7
	papaparse@​5.6.0
	@​tailwindcss/​forms@​0.5.11
	oxfmt@​0.62.0 ⏵ 0.63.0			+1
	js-yaml@​5.3.0
	pg@​8.23.0
	zod-openapi@​6.0.1
	oxlint@​1.77.0 ⏵ 1.78.0	+1		+1
	react-email@​6.9.2
	@​marsidev/​react-turnstile@​1.6.0
	dexie@​4.4.5
	react-hook-form@​7.85.0
	@​sentry/​node@​10.70.0
	@​sentry/​react@​10.70.0
	@​tanstack/​react-table@​9.1.2
	electron@​43.4.0

View full report

[socket-security]

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert  (click "▶" to expand/collapse)
Warn		Obfuscated code: npm @sentry/node-core is 60.0% likely obfuscated Confidence: 0.60 Location: Package overview From: pnpm-lock.yaml → npm/@sentry/node@10.70.0 → npm/@sentry/node-core@10.70.0 ℹ Read more on: This package | This alert | What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@sentry/node-core@10.70.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[paustint]

Code review summary

Automated review (Claude Code). Fixes below are pushed as an amend to the PR head.

Verdict: the Electron harness is well-built and closely matches the existing jetstream-e2e patterns. Remaining issues are packaging and CI wiring rather than test design.

Verified correct and not flagged: the security specs match the real implementation, token-at-rest is not racy (writeFileAtomic.sync), the Uint8Array evaluate-arg is serializable, temp userDataDir cleanup ordering is right, and the −1846 deletions dropped nothing valuable (stub scaffold + hoisted ci.yml + lockfile).

Fixed and pushed

• project.json — local e2e target had no build dependency. Local runs tested a stale or entirely absent dist/apps/jetstream-desktop/main.js. Now mirrors e2e-ci's dependsOn. Confirmed nx.json has no competing e2e.dependsOn and that jetstream-desktop:build defaults to production, so this hits the same cache entry CI uses.
• data-history-path-traversal.spec.ts — a security test that could pass without testing security. Bare .rejects.toThrow() passes for any rejection, including window.electronAPI is not available on this page. Both assertions now match their specific errors — /Invalid path segment/ and /Invalid data history user scope/, which are two different guards, so they're asserted separately rather than with one alternation. Verified no other bare toThrow() exists in the suite.

Needs a decision

• This branch is stacked on chore: dependency upgrade party #1979. Commits 0a6af97e1 and 9d8c52c14 belong to chore/dep-upgrade-082026, not here — which is why the diff shows ~30 prod dependency changes and 3.8k lockfile lines. Retargeting this PR's base to chore/dep-upgrade-082026 (or merging chore: dependency upgrade party #1979 first) drops the diff to just the E2E suite. No code change needed.
• The desktop-e2e CI job sits outside the required e2e gate ("pending a proven run"). Needs a follow-up to wire it in, or it rots as an ignored red check.
• Cold-start race (fixtures.ts:109): first launch races a cold Vite dev server against the 30s navigationTimeout because of the deferred module graph. Warming the dev server before Playwright starts would remove the flake.
• global.setup.ts:26 grants EXAMPLE_USER the desktop entitlement with no teardown — a local DB leak. Teardown or prisma seed?
• The commit body claims these fixtures live in @jetstream/test/e2e-utils; they don't. Prose fix.