Repository navigation
Conversation
#44 (blockquote laziness) and #45 (table detection) were merged in that order. #44 used PATTERN_TABLE_SEPARATOR in quoteLineState(), #45 deleted the constant, so every blockquote now throws "Error: Undefined constant Lexer::PATTERN_TABLE_SEPARATOR" on main (40 test errors). The check added nothing to blockquote laziness; drop it. (cherry picked from commit 7e799b1, pushed to the #44 branch after #44 had already been merged) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CPcuaaxrCottkeL1ykoSWe
…phpunit.xml - The size limit was checked before Unicode normalization, but NFC can grow the input (U+0958 has no composed form and doubles in size), so the parser could process more than maxBytes. The limit is now also checked on the normalized string. - .gitignore listed /phpunit.xml although it is the tracked PHPUnit config (an ignore rule has no effect on a tracked file and only misleads); the entries are removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CPcuaaxrCottkeL1ykoSWe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problèmes (points 15 et 16 de la review)
15. Limite
maxBytescontournable. La taille était vérifiée avant la normalisation NFC. Or NFC peut agrandir l'entrée : U+0958 n'a pas de forme composée et double de taille (3 → 6 octets). Le parser pouvait donc traiter jusqu'à environ 2×maxBytes.16.
.gitignorelistait/phpunit.xml, qui est pourtant la configuration PHPUnit versionnée. Une règle d'ignore n'a aucun effet sur un fichier suivi par git, elle ne fait qu'induire en erreur.Correctif
MarkdownParser::guard()revérifie la taille sur la chaîne normalisée, avec un message explicite (« after Unicode normalization »)./phpunit.xmlet/app/phpunit.xmlde.gitignore.Tests
testMaxBytesIsEnforcedAfterNormalization: 30 octets avant NFC, 60 après, limite à 40.🤖 Generated with Claude Code
https://claude.ai/code/session_01CPcuaaxrCottkeL1ykoSWe
Generated by Claude Code