Repository navigation
Added the XYZREF vector as a differentiated variable - #42
Merged
Merged
Conversation
joanibal
requested changes
Oct 15, 2025
| blk += self.ad_suffix | ||
| var += self.ad_suffix | ||
| val = ref_seeds[ref_key] * scale | ||
| val = ref_seeds[ref_key] * scale * np.ones(3) if ref_key == "XYZref" else ref_seeds[ref_key] * scale |
Owner
There was a problem hiding this comment.
What is going on here. Shouldn't ref_seeds[ref_key] have a shape of 3? A scalar value implies the three components will share one AD seed value which should not be the case.
Collaborator
Author
There was a problem hiding this comment.
It should. The tests were automatically making the seed 1.0 for everything and do avoid having changes across each test I thought I get it all here. Now I realize this function is also used by the actual sensitivity evaluations as well.
joanibal
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the XYZREF vector as a differentiated variable. Was accidentally added in the dictionary input PR but is now separated. All tests pass. Do not merge until dictionary input PR is merged.