[Accessibility] Keep sign-up confirmation content reachable with large text - #140
Draft
joashrajin wants to merge 1 commit into
Draft
joashrajin wants to merge 1 commit into
joashrajin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
The signup email-confirmation layout used an exact-height, vertically centered
LinearLayout. In a compact viewport at large font sizes, earlier content could consume the available height and leave the support message partially or completely clipped, with no way to scroll to it.Wrap the existing centered content in a fill-viewport
ScrollView. Content that fits remains centered; overflowing content is measured at its full height and can scroll. The existing text, link setup, spacing, artwork, and confirmation flow are unchanged.Test
925e6e0…) against exact forktrunka1280c2eand the fix on API 35, using the real layout, English production strings, a 320×424 compact fragment viewport, and 1×/2× font scales:SENTRY_AUTH_TOKENwas unset.:Simplenote:lintDebug: 0 errors, 263 warnings, 1 hint, with no finding on either changed path.Review
Please focus on the
fillViewportstructure: the innerwrap_contentlayout retains the existing centering when it fits, while theScrollViewgives oversized content a reachable overflow path.The Robolectric regression inflates the real layout with the authentication theme and production strings, but it does not launch
ConfirmationFragment, dispatch touch gestures, activate the email link, cover every locale or confirmation variant, verify scroll-position restoration, simulate TalkBack, or exercise physical hardware. The API 31 check was an emulator geometry probe rather than a full authentication flow.Before publication, neither changed path appeared in any open fork or upstream pull request. This branch is based directly on fork
trunk; no upstream branch or PR was written.Release
Signup confirmation messages remain readable and scrollable on compact screens at large text sizes.