Skip to content

[Accessibility] Reflow About privacy and terms links at large text - #143

Draft
joashrajin wants to merge 1 commit into
trunkfrom
codex/reflow-about-legal-links
Draft

joashrajin wants to merge 1 commit into
trunkfrom
codex/reflow-about-legal-links

Conversation

@joashrajin

Copy link
Copy Markdown
Owner

Fix

The About screen places Privacy Policy and Terms of Service in one horizontal row around a divider. On a 320dp viewport with German text at 200%, the existing layout gives the Terms link only 52px; the regression's minimum share is 104px.

Give both links equal layout weights so they participate in distributing the available width. Align Privacy Policy to the logical end of its view so the default-size labels remain grouped around the divider.

At the regression size, both labels render completely in two lines without ellipsis or leaving the row. At default English size, both remain single-line and grouped around the divider. The California privacy link, link destinations, click handlers, and horizontal row orientation are unchanged.

Test

  • Ran the same compiled AboutLegalLinksLayoutTest against exact fork trunk (a1280c2e) and the restored fix:
    • Base: 1/2 passed; the large-text case failed with Terms width 52px is below the 104px minimum share.
    • Fixed: 2/2 passed.
    • Test source SHA-256: e2cb820d615af9a31945f3e802dfdba441ac972cca0099b1e8142f6ab2c811d0.
    • Compiled class SHA-256: 57d314c5b73038cba4d439b08ff528c10cb970c84fa14b24e9d35e9f40490a95.
  • Ran the forced local matrix: 169/169 Gradle tasks executed successfully.
    • JVM tests: 306/306 across 35 suites.
    • Android-test sources compiled successfully (32 Kotlin and 17 Java class outputs); no device tests ran.
    • Roborazzi: 14/14 references unchanged.
    • Debug/release APKs, release AAB, and release mapping rebuilt; archives passed integrity checks.
    • The debug APK verifies with v1/v2 under the Android Debug certificate; the release APK/AAB are unsigned as expected locally.
    • Sentry mapping upload was excluded because SENTRY_AUTH_TOKEN was unset.
  • Ran :Simplenote:lintDebug: 0 errors, 263 warnings, 1 hint, with no finding on either changed path.

Review

Review the equal-weight width distribution and the Privacy link's viewEnd text alignment. Keeping each link at wrap_content preserves their intrinsic-width difference while the weights share the row's surplus or deficit.

The Robolectric regression inflates the production About layout with its localized Privacy and Terms strings on API 35 native graphics. It covers German at 200% and English at 100% in an exact 320x480dp mdpi fixture. It does not launch AboutActivity/AboutFragment, exercise links or browser navigation, simulate TalkBack, run RTL, cover all locales/scales, or run on a physical device.

Open fork PR #120 changes the shared About-link style to add minimum touch targets and vertical gravity. It is path-disjoint and composes with this layout, but the focused regression should be rerun if it lands first; this change does not claim touch-target improvements.

Before publication, neither changed path appeared in any of 112 open fork PRs or 8 open upstream PRs. This branch is based directly on fork trunk; no upstream branch or PR was written.

Release

Improved the About screen layout for Privacy Policy and Terms of Service when larger text is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant