[Accessibility] Reflow About privacy and terms links at large text - #143
Draft
joashrajin wants to merge 1 commit into
Draft
joashrajin wants to merge 1 commit into
joashrajin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
The About screen places Privacy Policy and Terms of Service in one horizontal row around a divider. On a 320dp viewport with German text at 200%, the existing layout gives the Terms link only 52px; the regression's minimum share is 104px.
Give both links equal layout weights so they participate in distributing the available width. Align Privacy Policy to the logical end of its view so the default-size labels remain grouped around the divider.
At the regression size, both labels render completely in two lines without ellipsis or leaving the row. At default English size, both remain single-line and grouped around the divider. The California privacy link, link destinations, click handlers, and horizontal row orientation are unchanged.
Test
AboutLegalLinksLayoutTestagainst exact forktrunk(a1280c2e) and the restored fix:Terms width 52px is below the 104px minimum share.e2cb820d615af9a31945f3e802dfdba441ac972cca0099b1e8142f6ab2c811d0.57d314c5b73038cba4d439b08ff528c10cb970c84fa14b24e9d35e9f40490a95.SENTRY_AUTH_TOKENwas unset.:Simplenote:lintDebug: 0 errors, 263 warnings, 1 hint, with no finding on either changed path.Review
Review the equal-weight width distribution and the Privacy link's
viewEndtext alignment. Keeping each link atwrap_contentpreserves their intrinsic-width difference while the weights share the row's surplus or deficit.The Robolectric regression inflates the production About layout with its localized Privacy and Terms strings on API 35 native graphics. It covers German at 200% and English at 100% in an exact 320x480dp mdpi fixture. It does not launch AboutActivity/AboutFragment, exercise links or browser navigation, simulate TalkBack, run RTL, cover all locales/scales, or run on a physical device.
Open fork PR #120 changes the shared About-link style to add minimum touch targets and vertical gravity. It is path-disjoint and composes with this layout, but the focused regression should be rerun if it lands first; this change does not claim touch-target improvements.
Before publication, neither changed path appeared in any of 112 open fork PRs or 8 open upstream PRs. This branch is based directly on fork
trunk; no upstream branch or PR was written.Release
Improved the About screen layout for Privacy Policy and Terms of Service when larger text is enabled.