[UX] Theme the Sustainer launcher icon - #147
Draft
joashrajin wants to merge 1 commit into
Draft
joashrajin wants to merge 1 commit into
joashrajin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
The legacy Sustainer launcher alias uses its own green adaptive icon, but that icon did not include the monochrome layer already used by Simplenote's primary launcher icon. On Android 13 and later, supported launchers use that layer when the user enables themed icons; before Android 16 QPR2, an icon without it falls back to its regular adaptive appearance. Android 16 QPR2 can generate a fallback, but an explicit layer remains the app-controlled rendering path.
Add the shared
ic_launcher_monolayer to the Sustainer icon. The primary and green foregrounds use the same path geometry and differ only by color, so the shared monochrome artwork preserves the intended silhouette. Unthemed rendering remains green; under themed icons, both launcher variants intentionally use the same dynamically tinted silhouette.Android references: themed icons in Android 13, adaptive icon guidance, and Android 16 QPR2 behavior.
Test
b43c4a25...) against exact forktrunka1280c2eand the fix on API 35:R.drawable.ic_launcher_mono.SENTRY_AUTH_TOKENwas unset.:Simplenote:lintDebug: 0 errors, 263 warnings, 1 hint, with no finding on either changed path.Review
Please focus on reusing the primary icon's monochrome artwork and on the intentional themed-mode tradeoff: the standard and Sustainer variants become the same launcher-supplied color, while the alternate icon remains green when themed icons are disabled.
The regression exercises compiled adaptive-icon inflation on Robolectric API 35 and pins the exact monochrome resource. It does not enable the launcher alias, exercise the preference toggle or launcher cache, render a themed icon, cover individual OEM launchers, or run on physical API 33/36 devices.
Before publication, neither changed path appeared in any of 116 open fork PRs or 9 open upstream PRs. Fork PR #139 changes the manifest, and upstream PR Automattic#1847 changes the Sustainer-related preference surface, but both are path-disjoint and preserve this launcher alias flow. This branch is based directly on fork
trunk; no upstream branch or PR was written.Release
The legacy Sustainer launcher icon now honors themed icons on supported Android launchers.