Fix ShareComponent crash on iPad - #75
Open
ansonhoyt wants to merge 1 commit into
Open
Conversation
UIActivityViewController requires popoverPresentationController.barButtonItem on iPad. Without it, presentation crashes with: "UIPopoverPresentationController should have a non-nil sourceView or barButtonItem set before the presentation occurs." Fixes joemasilotti#74 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Fixes an iPad crash in ShareComponent by configuring the UIActivityViewController popover anchor prior to presentation, aligning with UIKit’s iPad popover requirements.
Changes:
- Assigns
activityViewController.popoverPresentationController?.barButtonItembefore presenting the activity controller.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
ShareComponentcrash on iPad by settingpopoverPresentationController.barButtonItembefore presentingUIActivityViewControllerFixes #74
Tested
🤖 Patch generated with Claude Code