Skip to content

fix desktop switching on dvorak layouts#481

Open
laserbat wants to merge 1 commit into
joewing:masterfrom
laserbat:dvorak
Open

fix desktop switching on dvorak layouts#481
laserbat wants to merge 1 commit into
joewing:masterfrom
laserbat:dvorak

Conversation

@laserbat

@laserbat laserbat commented Jan 24, 2019

Copy link
Copy Markdown

Binding

<Key mask="A" key="#">desktop#</Key>

doesn't work correctly on some dvorak layouts, namely programmers dvorak and classic dvorak, since on these layouts keys that are typically number keys are used for other purpose and have different keysyms.

To work around this issue this patch uses keycodes (which are consistent between layouts) to get the correct keysym.

@rdnvndr

rdnvndr commented Jan 25, 2019

Copy link
Copy Markdown
Contributor

Do other hot keys work correctly in the dvorak layout?
For example:

<Key mask="CA" key="t">exec:xterm </Key>

@laserbat

Copy link
Copy Markdown
Author

Yes, other hotkeys work as they should.

@rdnvndr

rdnvndr commented Jan 26, 2019

Copy link
Copy Markdown
Contributor

I think the problem not in JWM (without patch). I run command:

setxkbmap -v us -variant dvorak

Changing the desktop works. I using Archlinux.

@laserbat

Copy link
Copy Markdown
Author

As I've said, problem is with classic and progremmer's dvorak variants. The problem arises because of non-standard layout of number keys: https://www.kaufmann.no/roland/dvorak/images/dvp1.png

Try this

setxkbmap -layout us -variant dvp

@rdnvndr

rdnvndr commented Jan 26, 2019

Copy link
Copy Markdown
Contributor

I exec JWM by commands:

setxkbmap -layout us -variant dvp
jwm

I press the key CAPSLOCK
I press the keys ALT + 3

The desktop is changing

@laserbat

Copy link
Copy Markdown
Author

Yes, this works, but it's inconvenient to have to use caps lock to switch desktops.

@rdnvndr

rdnvndr commented Jan 27, 2019

Copy link
Copy Markdown
Contributor

It works for me without CAPSLOCK. I suggested that you have a problem with this.

PS: I also use a xorg-server 1.20.3 with a patch https://aur.archlinux.org/packages/xorg-server-bug865. Perhaps this will help when looking for a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants