Add more docs and test coverage for matcbox_socket - #539
Merged
Conversation
Craig-Macomber
commented
Feb 14, 2026
| .ok_or(ChannelError::NotFound)?; | ||
|
|
||
| self.take_channel(pos) | ||
| self.take_channel(peer_index) |
Contributor
Author
There was a problem hiding this comment.
I think take_channel_by_id is broken as it uses the peer_index as the channel_index, but I'll leave removing this broken API for a separate change as that impacts the API and doesn't belong in this one.
The fact that I think it is broken is why I did not include a test for it (that and testing it requires a connected peer to do anything except just error).
Owner
There was a problem hiding this comment.
Oh, yeah, that's bad. Shows why we need better test coverage.
johanhelsing
left a comment
johanhelsing
left a comment
Owner
There was a problem hiding this comment.
Nitpicks, otherwise looks great! Thanks!
Co-authored-by: Johan Klokkhammer Helsing <johanhelsing@gmail.com>
Co-authored-by: Johan Klokkhammer Helsing <johanhelsing@gmail.com>
Co-authored-by: Johan Klokkhammer Helsing <johanhelsing@gmail.com>
johanhelsing
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings test coverage for matcbox_socket up from 16% to 19% according to cargo tarpaulin, and clarifies a few docs to make clear the details I found out while testing.