Remove APIs which use peer index as channel index - #542
Merged
Conversation
johanhelsing
approved these changes
Feb 16, 2026
johanhelsing
left a comment
johanhelsing
left a comment
Owner
There was a problem hiding this comment.
Sounds like the right call. I'm not sure who added it, and when, but it probably never worked.
Contributor
Author
The bug seems to have been introduced in 62c783c, which converted the method added in 414f973 to be bugged differently. I think what was missing in those attempts is the fact that if you want to get a raw channel to a single peer, one must take either the channel, then take a peer from the WebRtcChannel. Implementing that might actually be the easiest way to exposing the a clean async interface with back-pressure I want, though I'll try and make it practical to unit test such a setup before I go to implement it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since channels are internally organized by index, not peer, there isn't an easy way to implement taking channels for a single peer. Thus this simple removes the incorrectly implemented APIs rather than trying to fix them.