Support fully using dulwich#342
Open
jelmer wants to merge 4 commits into
Open
Conversation
Use dulwich.porcelain.push() instead of subprocess.call() for git push operations in the test suite to reduce external dependencies.
Use dulwich.porcelain.clone() and repo.reset_index() instead of subprocess calls to git clone and git checkout for creating temporary repository clones.
Use dulwich.repo.Repo to get the current commit SHA instead of subprocess.check_output() with git log. This removes another external git dependency.
Implement dulwich alternatives for git log and git blame operations in repo.py. The FULL_DULWICH flag (default False) allows switching between pure-Python dulwich implementation and git subprocess calls. This gives users the option to use the faster subprocess approach if needed while defaulting to the pure-Python implementation. - Replace history() method's git log with dulwich's get_walker - Replace blame() method's git blame with dulwich.porcelain.blame - Keep subprocess implementations available when FULL_DULWICH=False
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement dulwich alternatives for git log and git blame operations in
repo.py. The FULL_DULWICH flag (default False) allows switching between
pure-Python dulwich implementation and git subprocess calls. This gives
users the option to use the faster subprocess approach if needed while
defaulting to the pure-Python implementation.