Repository navigation
fix(zotero): preserve model preparation across reading context changes - #1308
Merged
Merged
Conversation
This was referenced Oct 24, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preparing a local encoder no longer shares the chat abort controller. Changing the selected Zotero item or reader while Granite downloads now leaves library preparation running. Settings displays the active model, live progress, errors and a dedicated cancel action; failed targets remain selected for retry. Prepare also validates the active encoder and computes missing vectors instead of silently returning.
Existing E5 vectors no longer count as an explicit choice. Installations without a saved model preference adopt Granite; successful explicit selections remain respected.
Closes #1307
Validation
Granite activationwhen a synthetic book is selected during the download; the corrected code passes activation, vector reuse, cancellation, per-item history, restart/deletion and credential checks.git diff --checkpass.Compatibility and versioning
The corrected local XPI remains 5.15.5 until the next release, as requested by the maintainer; the desktop/server release version is unchanged. Model weights, vector contracts and retrieval semantics are unchanged.
English and Spanish settings feedback is included. Before/after details and reproduction command:
audit/zotero-embeddings/activation-fix.md.