Skip to content

fix(zotero): preserve model preparation across reading context changes - #1308

Merged
jorgepb96 merged 2 commits into
mainfrom
codex/zotero-model-activation-fix
Oct 23, 2026
Merged

jorgepb96 merged 2 commits into
mainfrom
codex/zotero-model-activation-fix

Conversation

@jorgepb96

Copy link
Copy Markdown
Owner

Summary

Preparing a local encoder no longer shares the chat abort controller. Changing the selected Zotero item or reader while Granite downloads now leaves library preparation running. Settings displays the active model, live progress, errors and a dedicated cancel action; failed targets remain selected for retry. Prepare also validates the active encoder and computes missing vectors instead of silently returning.

Existing E5 vectors no longer count as an explicit choice. Installations without a saved model preference adopt Granite; successful explicit selections remain respected.

Closes #1307

Validation

  • 108 plugin regression tests pass, including item changes during model preparation, visible error/retry state, preparing the active model and upgrade defaults with historical E5 data.
  • Native before/after reproduction on Zotero 10.0.6/macOS ARM64: the previous package fails Granite activation when a synthetic book is selected during the download; the corrected code passes activation, vector reuse, cancellation, per-item history, restart/deletion and credential checks.
  • Syntax checks, packaged XPI integrity and git diff --check pass.
  • All local inference tests run sequentially in disposable profiles. No personal library is opened.

Compatibility and versioning

The corrected local XPI remains 5.15.5 until the next release, as requested by the maintainer; the desktop/server release version is unchanged. Model weights, vector contracts and retrieval semantics are unchanged.

English and Spanish settings feedback is included. Before/after details and reproduction command: audit/zotero-embeddings/activation-fix.md.

@jorgepb96
jorgepb96 merged commit 96cde64 into main Oct 23, 2026
5 of 7 checks passed
This was referenced Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Zotero model activation cancellation and migrate the implicit E5 default to Granite

1 participant