Repository navigation
feat(ideas,authors): open filters as a balloon instead of an inline strip - #1325
Merged
Merged
Conversation
Contributor
|
@jorgepb96, all required checks have passed for the latest revision of this PR. It is ready for maintainer review and merge consideration. Latest revision: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1324.
Summary
The filter buttons in Ideas and Authors expanded an inline strip above the catalogue. Opening it pushed the table down by 56 px and read as if the section itself had expanded, instead of as a cut applied to the list.
Both sections now open a floating balloon anchored under the Filters button, using the same
useDismissableLayerpattern and visual treatment as the Library filter panel:src/views/IdeasView.tsx): Type and Order in a 240 px balloon.src/views/AuthorsView.tsx): Saved authors, Synthesis and Order in a 256 px balloon.role="dialog",aria-haspopup="dialog",aria-expandedandaria-controls; the existingdata-testidhooks (ideas-type-filter,ideas-sort,authors-tab-saved) are unchanged.max-w-[calc(100vw-3rem)]so it cannot overflow a narrow window.No strings were added: every label already existed.
Related issue
Closes #1324
Type of change
Validation
npx eslint src/views/IdeasView.tsx src/views/AuthorsView.tsxnpm run typechecknode --test scripts/test-ideas-ui.mjs scripts/test-authors-ui.mjs— 12/12, with two new assertions pinning the balloon dialog and its dismissal group.npx vite build— the build used for the Electron captures.node scripts/e2e-saved-authors.mjs— passes against the built Electron app (opens Filters, enables saved authors, searches, reloads and keeps the state).npm testand the fullnpm run buildare left to CI; the focused checks above cover the changed views.Screenshots
Before/after captures were taken in dark and light from an isolated synthetic profile of the built app, and kept out of the repository:
before-ideas-filters.png,before-authors-filters.png: inline strip pushing the table down 56 px.after-ideas-filters.png,after-authors-filters.png: balloon over the table, catalogue unmoved.after-ideas-filtered.png,after-authors-saved-filter.png: filters applied with the balloon open.after-light-ideas-filters.png,after-light-authors-filters.png: light theme.Privacy and data review
Contributor checklist
CONTRIBUTING.mdandCODE_OF_CONDUCT.md.