fix: wrap httpx timeouts as RequestTimeoutError#48
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Rename the library timeout exception to RequestTimeoutError to avoid shadowing Python's built-in TimeoutError, while keeping TimeoutError as a backwards-compatible alias. HTTP and streaming layers now convert httpx.TimeoutException into RequestTimeoutError so callers and failover logic get a consistent, typed timeout error instead of raw httpx exceptions. Co-authored-by: Darshan Harihar <DarshanHarihar1@users.noreply.github.com>
Co-authored-by: Darshan Harihar <DarshanHarihar1@users.noreply.github.com>
github-actions
Bot
added
core
tests
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes inconsistent timeout error handling in the HTTP layer.
justllms.exceptions.TimeoutErrorwas defined but never raised — httpx timeouts bubbled up as rawhttpx.TimeoutExceptioninstead. The class also shadowed Python's built-inTimeoutError.Changes
RequestTimeoutErroras the canonical timeout exceptionTimeoutErroras a backwards-compatible aliasraise_from_httpx_error()helper to map httpx transport errors to library exceptionsBaseProvider._make_http_request()andparse_sse_stream()tests/test_http_errors.pyBranch
Feature branch:
darshan/wrap-httpx-timeout-errorsTesting
All CI checks pass locally:
ruff check justllms/black --check justllms/ tests/mypy justllms/ --ignore-missing-importspytest tests/ -v(100 passed)python3 -m build