fix: register provider aliases (xai/grok) on client init#50
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
When XAI_API_KEY is loaded via Config.from_env(), the grok provider is initialized but the xai alias was missing. SXS and explicit provider='xai' calls failed with Provider not found. Register all known aliases (xai, claude, gemini) that share the same provider class after initialization, without overwriting explicitly configured alternate names. Co-authored-by: Darshan Harihar <DarshanHarihar1@users.noreply.github.com>
github-actions
Bot
added
core
tests
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where provider aliases registered in
justllms.providers(e.g.xai→GrokProvider) were not exposed on theClientafter initialization.When
XAI_API_KEYis loaded viaConfig.from_env(), only thegrokprovider was registered. SXS and explicitprovider="xai"calls failed withProvider 'xai' not found.Changes
_register_provider_aliases()to register alternate names that share the same provider class after init_initialize_providers()andadd_provider()tests/test_provider_aliases.pyFeature branch:
darshan/fix-provider-alias-registrationTesting
ruff check justllms/black --check justllms/mypy justllms/ --ignore-missing-importspytest tests/ -v(98 tests)python -m build