Skip to content

skip validation of conditions.notBefore if it is not provided #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
endrus wants to merge 2 commits into
base: master
Choose a base branch
from
Open

skip validation of conditions.notBefore if it is not provided #82

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e97b2f8
skip validation of conditions.notBefore if it is not provided
andrzejstasiakepassi May 6, 2021
9003f9c
Merge branch 'master' into feature-validation-when-no-notBefore
endrus Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/main/java/com/coveo/saml/ValidatorUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,13 @@ private static void enforceConditions(Conditions conditions, Instant _now, long
throws SamlException {
Instant now = _now != null ? _now : Instant.now();

Instant notBefore = conditions.getNotBefore();
Instant skewedNotBefore = notBefore.minusSeconds(notBeforeSkew);
if (now.isBefore(skewedNotBefore)) {
throw new SamlException("The assertion cannot be used before " + notBefore.toString());

if (conditions.getNotBefore() != null) {
Instant notBefore = conditions.getNotBefore();
Instant skewedNotBefore = notBefore.minusSeconds(notBeforeSkew);
if (now.isBefore(skewedNotBefore)) {
throw new SamlException("The assertion cannot be used before " + notBefore.toString());
}
}

Instant notOnOrAfter = conditions.getNotOnOrAfter();
Expand Down