Run session tests in CI alongside routing tests - #2
Merged
Merged
Conversation
tests/test-session.scm (cookies, sessions, auth — 21 checks) was only exercised by the org nightly workflow, so PR-level regressions in session and auth code went uncaught until the next nightly run — as happened with the session id collision fixed in #1. Each test file writes its own Cobertura XML so the second run does not overwrite the first's coverage; Codecov uploads both. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1:
tests/test-session.scm(cookies, sessions, auth — 21 checks) was only exercised by the org nightly workflow, so PR-level regressions in session/auth code went uncaught until the next nightly run — which is exactly how the session id collision fixed in #1 surfaced.Changes
coverage-routing.xml,coverage-session.xml) so the second run doesn't overwrite the first's coverage; the Codecov step uploads both.Not included:
tests/test-app.sh/test-app-server.scm— the script hardcodes sibling-checkout lib paths ($DIR/../../kaappi-http) that don't match CI's/tmpclone layout, so it would need its own rework to be CI-safe.Verification
Ran the exact new command shape locally against a main-built kaappi: 21/21 checks pass and valid Cobertura XML is produced. This PR's own CI run exercises the new step directly.
🤖 Generated with Claude Code