+ prometheus: add configuration parameters to the accumulator#1382
Open
Iilun wants to merge 1 commit into
Open
+ prometheus: add configuration parameters to the accumulator#1382Iilun wants to merge 1 commit into
Iilun wants to merge 1 commit into
Conversation
Iilun
force-pushed
the
777-configure-prometheus-periods
branch
from
9b3a579 to
14f9b13
Compare
Contributor
|
@ivantopo this one please a well, thanks! |
Author
|
@ivantopo Is it possible to take a look at this ? Thank you very much ! |
Author
|
@ivantopo Do you have an opinion on this PR ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal
As mentioned in #777, and some discord conversations, the issue of prometheus keeping removed metrics for 5 years can sometimes cause issues.
Choices
The current configuration behavior does not handle reconfiguration. I did not want to make choices on whether to keep data or not if a reload had to modify the snapshot accumulator, and unsure if making the accumulator variable was a good idea anyway. I am of course open to feedback on this issue