Skip to content

Minor change to dependencies in Cargo.toml - #59

Merged
scabrero merged 2 commits into
kanidm:mainfrom
Firstyear:20260703-minor-change
Jul 7, 2026
Merged

Minor change to dependencies in Cargo.toml#59
scabrero merged 2 commits into
kanidm:mainfrom
Firstyear:20260703-minor-change

Conversation

@Firstyear

Copy link
Copy Markdown
Member

Only include limited tokio features, and use assert-hex only in test builds.

Only include limited tokio features, and use assert-hex only in test builds.
@Firstyear
Firstyear requested a review from scabrero July 3, 2026 05:24
@scabrero

scabrero commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Hi @Firstyear, this change issues the following warning:

warning: <redacted>/libkrimes/Cargo.toml: `default-features` is ignored for tokio, since `default-features` was not specified for `workspace.dependencies.tokio`, this could become a hard error in the future

Could you please add it to the main Cargo.toml?

diff --git a/Cargo.toml b/Cargo.toml
index 3b4da7a..0ac59db 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -46,7 +46,7 @@ sha1 = "0.10.6"
 tempfile = "3.19.1"
 tracing = { version = "0.1" }
 tracing-subscriber = { version = "0.3" }
-tokio = { version = "1", features = [
+tokio = { version = "1", default-features = false, features = [
   "macros",
   "rt",
   "net",

@Firstyear

Copy link
Copy Markdown
Member Author

Interesting, I tested this and I didn't get that error - I wonder if you are using a different version of rust than I am? (I'm on 1.96).

Anyway, changed the cargo.toml to be sure anyway :)

@scabrero

scabrero commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Interesting, I tested this and I didn't get that error - I wonder if you are using a different version of rust than I am? (I'm on 1.96).

I am on cargo 1.96.1 (356927216 2026-06-26)

Anyway, changed the cargo.toml to be sure anyway :)

Thanks!

@scabrero
scabrero merged commit 6817ad0 into kanidm:main Jul 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants