Add PICOJSON_DISABLE_EXCEPTION macro switch to support -fno-exceptions - #118
Open
rhysd wants to merge 1 commit into
Open
Add PICOJSON_DISABLE_EXCEPTION macro switch to support -fno-exceptions#118rhysd wants to merge 1 commit into
rhysd wants to merge 1 commit into
Conversation
rhysd
force-pushed
the
allow-disable-exception
branch
from
May 28, 2019 11:38
e3b558b to
ae24181
Compare
rhysd
changed the title
|
Looks good IMO, this would be useful for some cases I'm interested in. |
|
@kazuho : Anything blocking to get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #117
For supporting
-fno-exceptionscompiler option, this patch addsPICOJSON_DISABLE_EXCEPTIONpreprocessor macro switch. When it is defined, picojson utilizesstd::abortinstead ofthrow.I confirmed
picojson.hcan be compiled withclang++ -fno-exceptionwith this patch and all tests passed bymake test.