fix/highlight log errors - #2082
Open
alanpeixinho wants to merge 3 commits into
Open
Conversation
* Match fail with word boundary to exclude pipefail * Skip error_mode and _0_errors in LAVA test names * Skip kselftest # Totals: header lines * Extend highlight tests for filtered cases Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
* Rename chips to Suspected fail, Suspected error, Other matches * Add tooltip that heuristic counts may not match test status * Update locale strings Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
Comment on lines
+170
to
+172
| newCode = newCode.replace(/^.*(error|\bfail).*$/gim, match => { | ||
| if (/^\s*# Totals:/i.test(match)) { | ||
| return match; |
Member
There was a problem hiding this comment.
I don't get this. What I see in database is:
# # Totals: pass:1 fail:0 ...
and
[timestamp] # Totals: ...
I don't see what this line wants to match
Contributor
Author
There was a problem hiding this comment.
Nice catch. This was incorrect, and to be fair, might not be worth including.
Contributor
Author
There was a problem hiding this comment.
I am keeping only the error_mode and _0_errors false positives here.
Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(log-viewer): reduce highlight false positives and clarify counts (#2065, #2066)
Closes #2065
Closes #2066
What it is
failwith word boundary (\bfail) — fixespipefailfalse positives (Log viewer: exclude "pipefail" from the highlight heuristic #2065)error_modeand_0_errorsLAVA test names before highlighting (Log viewer: exclude "pipefail" from the highlight heuristic #2065)30-day DB analysis (36k test excerpts):
error_mode_0_errorsHow to Test
error_modeor_0_errorsin log — no highlight counts# Totals:lines still highlight when they report real failures