Updated kci-dev command generator - #2084
Conversation
Signed-off-by: Arisu Tachibana <alicef@gentoo.org>
full-sized CLI command button with safe asynchronous clipboard handling Signed-off-by: Arisu Tachibana <alicef@gentoo.org>
|
example: |
Signed-off-by: Arisu Tachibana <alicef@gentoo.org>
Signed-off-by: Arisu Tachibana <alicef@gentoo.org>
Signed-off-by: Arisu Tachibana <alicef@gentoo.org>
|
Made kci-dev more visible
|
| <div className="flex flex-wrap justify-end gap-2"> | ||
| {kcidevComponent} | ||
| </div> | ||
| <div className="flex flex-wrap justify-end gap-2"></div> |
alanpeixinho
left a comment
alanpeixinho
left a comment
There was a problem hiding this comment.
Nice work @aliceinwire. Left a few comments.
| testPaths: enabledValues( | ||
| result === 'boots' ? record.bootPath : record.testPath, | ||
| ), | ||
| bootOrigins: enabledValues(record.bootOrigin), |
There was a problem hiding this comment.
Dont we need built and test origin filters as well?
| <FormattedMessage id="footer.cliCommand" /> | ||
| </Button> | ||
| </PopoverTrigger> | ||
| <PopoverContent |
There was a problem hiding this comment.
I think we can present this information in a more concise way, especially by using icons in the buttons.
Also, the install kci-dev command is always present, so we could take it off the Popover.
This is just a proposal, there might be better ways to present the popover.
| }; | ||
|
|
||
| export type KcidevCommandVariant = { | ||
| id: 'human' | 'json' | 'download' | 'gate' | 'gate-json'; |
There was a problem hiding this comment.
do we really need to include variants of commands?
If it is important to include every variant, cant we just ad d a radio (or another way to select), so we dont show of them at the start.
| issueCulprits?: readonly string[]; | ||
| issueCategories?: readonly string[]; | ||
| issueOptions?: readonly string[]; | ||
| hasExactDateBoundaries?: boolean; |
There was a problem hiding this comment.
are we using this parameter?
| ]; | ||
|
|
||
| const appendOption = (argv: string[], option: string, value?: string): void => { | ||
| if (value !== undefined) { |
There was a problem hiding this comment.
might be safe to filter out empty string as well
| omittedFilters: [...new Set(omittedFilters)], | ||
| reproduction: omittedFilters.length === 0 ? 'exact' : 'partial', | ||
| }; | ||
| result.variants = variants ?? standardVariants(argv); |
There was a problem hiding this comment.
nit: cant we just initialize variants with the object initialization here
| id: 'download', | ||
| label: 'Download logs (writes files)', | ||
| argv: [...argv, '--download-logs'], | ||
| writesFiles: true, |
| label: string; | ||
| argv: readonly string[]; | ||
| omittedFilters: readonly string[]; | ||
| reproduction: 'exact' | 'partial'; |
There was a problem hiding this comment.
Is this prop being read?
2 participants
No description provided.