tarball: clean up incomplete repository clones - #1589
Merged
nuclearcat merged 1 commit intoAug 31, 2026
Conversation
When update_repo fails while cloning a repository, Git can leave the destination absent or partially initialized without a .git directory. The current error path treats this state as a safeguard violation and raises an exception, preventing the existing retry logic from attempting a fresh clone. This was observed in production when the media_next remote returned HTTP 502. Clean up the destination even when it is not yet a Git repository, then return the existing retry signal. Use shutil.rmtree() for directories and unlink symlinks directly instead of invoking rm through a shell. A transient clone failure can now retry from a clean destination rather than terminating the tarball service with a secondary "not a git repo" error. Signed-off-by: Denys Fedoryshchenko <denys.f@collabora.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When update_repo fails while cloning a repository, Git can leave the destination absent or partially initialized without a .git directory. The current error path treats this state as a safeguard violation and raises an exception, preventing the existing retry logic from attempting a fresh clone. This was observed in production when the media_next remote returned HTTP 502.
Clean up the destination even when it is not yet a Git repository, then return the existing retry signal. Use shutil.rmtree() for directories and unlink symlinks directly instead of invoking rm through a shell. A transient clone failure can now retry from a clean destination rather than terminating the tarball service with a secondary "not a git repo" error.