Clarify error when cassette is missing in write-protected mode (#838) - #1027
Open
philsong4-ai wants to merge 2 commits into
Open
philsong4-ai wants to merge 2 commits into
philsong4-ai wants to merge 2 commits into
Conversation
…1024#838) In record modes that forbid recording (e.g. 'none'), requesting an interaction that is not in the cassette raised CannotOverwriteExistingCassetteException with the message "Can't overwrite existing cassette (...)". That wording is misleading when the cassette file does not actually exist yet. Now the exception distinguishes the two cases: - The cassette file exists: the original 'Can't overwrite existing cassette' message is preserved (unchanged behavior). - The cassette file does not exist: a clearer message explains that the cassette is missing and the current record mode does not allow recording new requests. The exception gains an optional 'message' argument so callers can supply an overridden message; existing call sites are unaffected. Adds a regression test asserting the clearer message for kevin1024#838.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In record modes that forbid recording (e.g. 'none'), requesting an interaction that is not in the cassette raised
CannotOverwriteExistingCassetteException with the message "Can't overwrite existing cassette (...)". That wording is misleading when the cassette file does not actually exist yet.
Now the exception distinguishes the two cases:
The exception gains an optional 'message' argument so callers can supply an overridden message; existing call sites are unaffected.
Adds a regression test asserting the clearer message for #838.