Skip to content

change(android): clean up site deep-link configuration - #16438

Merged
jahorton merged 1 commit into
fix/android/load-external-kmp-filefrom
change/android/clean-site-deep-links
Sep 2, 2026
Merged

change(android): clean up site deep-link configuration#16438
jahorton merged 1 commit into
fix/android/load-external-kmp-filefrom
change/android/clean-site-deep-links

Conversation

@jahorton

@jahorton jahorton commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Build-bot: skip release:android

Follows up on this comment chain: #16392 (comment)

User Testing

GROUP_API_28: Perform these tests on devices with Android API 28 (Android 9).
GROUP_API_30: Perform these tests on devices with Android API 30 (Android 11).
GROUP_API_33: Perform these tests on devices with Android API 33+ (Android 13).

TEST_CHROME_SEARCH_DOWNLOAD: With Keyman for Android installed on the test device, verify that the keyboard-search result pages' big green buttons auto-redirect to the Keyman app.

  1. Navigate to keyman.com
  2. Use the keyboard search (pick any language / keyboard) and select a result.
  3. From that result's page, click the big green "Install Keyboard" button.
  4. Verify that Keyman for Android automatically opens and attempts to install the keyboard package.

@github-project-automation github-project-automation Bot moved this to Todo in Keyman Aug 25, 2026
@keymanapp-test-bot keymanapp-test-bot Bot added has-user-test user-test-required User tests have not been completed labels Aug 25, 2026
@keymanapp-test-bot

keymanapp-test-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown

User Test Results

Test specification and instructions

  • ✅ GROUP_API_28: Perform these tests on devices with Android API 28 (Android 9).

    1 tests PASSED
  • ✅ GROUP_API_30: Perform these tests on devices with Android API 30 (Android 11).

    1 tests PASSED
  • ✅ GROUP_API_33: Perform these tests on devices with Android API 33+ (Android 13).

    1 tests PASSED

Test Artifacts

@keymanapp-test-bot keymanapp-test-bot Bot added this to the A19S36 milestone Aug 25, 2026
@github-actions github-actions Bot added android/ android/app/ change Minor change in functionality, but not new labels Aug 25, 2026

@mcdurdin mcdurdin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice cleanup.

Noting that this merges two <intent-filter>s which both related to keyman.com (and keyman-staging.com). The outcome does not change, and this makes the manifest somewhat easier to read.

@Meng-Heng Meng-Heng self-assigned this Aug 27, 2026
@Meng-Heng

Copy link
Copy Markdown
Contributor

Test Results

GROUP_API_28:

  • TEST_CHROME_SEARCH_DOWNLOAD (FAILED):
  1. On Pixel 3a XL, Android 9.0, API 28
  2. Install Keyman
  3. Go to Chrome -> Type keyman.com -> Search "english" -> The page stays the same
  4. Go to Keyman -> Install keyboard from keyman.com -> Search "english" -> The page stays the same
  5. FAILED: No keyboard appear from the search action.

GROUP_API_30:

  • TEST_CHROME_SEARCH_DOWNLOAD (PASSED):
  1. On Pixel 5, Android 11.0, API 30
  2. Install Keyman
  3. Go to Chrome -> Type keyman.com -> Search "english" -> Tap on EuroLatin (SIL)
  4. Click on the green install keyboard button
  5. Keyman for Android automatically opens and attempts to install the keyboard package
  6. VERIFIED: The keyboard installs successfully.

GROUP_API_33:

  • TEST_CHROME_SEARCH_DOWNLOAD (PASSED):
  1. On Pixel 6a, Android 13.0, API 33
  2. Install Keyman
  3. Go to Chrome -> Type keyman.com -> Search "khmer" -> Tap on Khmer (SIL)
  4. Click on the green install keyboard button
  5. Keyman for Android automatically opens and attempts to install the keyboard package
  6. VERIFIED: The keyboard installs successfully.

@keymanapp-test-bot keymanapp-test-bot Bot added user-test-failed and removed user-test-required User tests have not been completed labels Aug 27, 2026
@jahorton

Copy link
Copy Markdown
Contributor Author

GROUP_API_28:

* **TEST_CHROME_SEARCH_DOWNLOAD (FAILED):**


1. On Pixel 3a XL, Android 9.0, API 28

2. Install Keyman

3. Go to Chrome -> Type keyman.com -> Search "english" -> The page stays the same

4. Go to Keyman -> Install keyboard from keyman.com -> Search "english" -> The page stays the same

5. FAILED: No keyboard appear from the search action.

I'm running into this problem as well when trying to do this via Android Studio emulator. I get stuck with an old Chrome WebView, and can't even get the Chrome debugger operational.

Could you try directly typing keyman.com/keyboards/install/khmer_angkor into the Chrome address bar?

@Meng-Heng

Meng-Heng commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Test Results

GROUP_API_28:

  • TEST_CHROME_SEARCH_DOWNLOAD (PASSED):
  1. On Pixel 3a XL, Android 9.0, API 28
  2. Install Keyman
  3. Go to Chrome -> Type keyman.com/keyboards/install/khmer_angkor -> Click "Khmer Angkor keyboard home"
  4. Click on the green install keyboard button
  5. Keyman for Android automatically opens and attempts to install the keyboard package
  6. VERIFIED: The keyboard installs successfully.
Screen.Recording.2026-08-28.at.3.41.41.in.the.afternoon.mov

@Meng-Heng

Copy link
Copy Markdown
Contributor

I navigated to the keyboard home page through keyman.com/keyboards/install/khmer_angkor so hopefully it is the right steps to follow.

@Meng-Heng Meng-Heng removed their assignment Aug 28, 2026
@mcdurdin

Copy link
Copy Markdown
Member

So is there a breaking problem with the keyman.com site on Android 9 / API 28? Can we check that separately?

@keyman-server keyman-server modified the milestones: A19S36, B19S1 Aug 30, 2026
@jahorton

jahorton commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

So is there a breaking problem with the keyman.com site on Android 9 / API 28? Can we check that separately?

It's more a problem with emulating an Android API 28 device... I think? The default Chrome predates Chrome 95 significantly, which is what we generally target, right?

@mcdurdin

mcdurdin commented Sep 2, 2026

Copy link
Copy Markdown
Member

OK, yes, then in that case I am okay with this.

@jahorton
jahorton merged commit abb2b82 into fix/android/load-external-kmp-file Sep 2, 2026
8 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Keyman Sep 2, 2026
@jahorton
jahorton deleted the change/android/clean-site-deep-links branch September 2, 2026 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

android/app/ android/ change Minor change in functionality, but not new has-user-test

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants