Skip to content

refactor(windows): cleanup unused wm_keyman_control values - #16439

Merged
mcdurdin merged 1 commit into
masterfrom
refactor/windows/15333-cleanup
Sep 1, 2026
Merged

refactor(windows): cleanup unused wm_keyman_control values#16439
mcdurdin merged 1 commit into
masterfrom
refactor/windows/15333-cleanup

Conversation

@mcdurdin

@mcdurdin mcdurdin commented Aug 26, 2026

Copy link
Copy Markdown
Member

Cleanup of unused wm_keyman_control and wm_keyman_refresh values, and some other unused messages, which were making the implementation harder to understand.

Relates-to: #15333
Follows: #16435
Test-bot: skip

@mcdurdin
refactor(windows): cleanup unused wm_keyman_control values
2c7bba8 
Cleanup of unused `wm_keyman_control` and `wm_keyman_refresh` values,
and some other unused messages, which were making the implementation
harder to understand.

Relates-to: #15333
Follows: #16435
@github-project-automation github-project-automation Bot moved this to Todo in Keyman Aug 26, 2026
@keymanapp-test-bot

keymanapp-test-bot Bot commented Aug 26, 2026 •
edited
Loading

Copy link
Copy Markdown

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

  • Windows
    • Keyman for Windows - build : all tests passed (no artifacts on BuildLevel "build")
    • FirstVoices Keyboards for Windows - build : all tests passed (no artifacts on BuildLevel "build")
    • Text Editor (ARM64) - build : all tests passed (no artifacts on BuildLevel "build")
    • Text Editor (x64) - build : all tests passed (no artifacts on BuildLevel "build")
    • Text Editor (x86) - build : all tests passed (no artifacts on BuildLevel "build")

@keymanapp-test-bot keymanapp-test-bot Bot added this to the A19S36 milestone Aug 26, 2026
@mcdurdin
mcdurdin requested a review from rc-swag August 26, 2026 08:22
@keyman-server keyman-server modified the milestones: A19S36, B19S1 Aug 30, 2026
rc-swag
rc-swag approved these changes Sep 1, 2026
View reviewed changes

@rc-swag rc-swag left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from fix/windows/15333-simplify-keyboard-refresh to master September 1, 2026 09:10
@mcdurdin
mcdurdin merged commit 947dbe9 into master Sep 1, 2026
10 checks passed
@mcdurdin
mcdurdin deleted the refactor/windows/15333-cleanup branch September 1, 2026 09:11
@github-project-automation github-project-automation Bot moved this from Todo to Done in Keyman Sep 1, 2026
@keyman-server

keyman-server commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 19.0.277-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rc-swag rc-swag rc-swag approved these changes

Assignees

No one assigned

Labels

refactor windows/config/ windows/engine/ windows/

Projects

Keyman
Status: Done

Milestone

B19S1

Development

Successfully merging this pull request may close these issues.

3 participants

@mcdurdin @keyman-server @rc-swag