Skip to content

refactor(windows): rename GetCapsAndNumlockState() to RefreshModifierState() - #16444

Merged
mcdurdin merged 2 commits into
masterfrom
refactor/windows/16434-rename-to-RefreshModifierState
Sep 1, 2026
Merged

refactor(windows): rename GetCapsAndNumlockState() to RefreshModifierState()#16444
mcdurdin merged 2 commits into
masterfrom
refactor/windows/16434-rename-to-RefreshModifierState

Conversation

@mcdurdin

Copy link
Copy Markdown
Member

Rebase after #16423 lands.

Fixes: #16434
Test-bot: skip

@keymanapp-test-bot

keymanapp-test-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

User Test Results

Test specification and instructions

User tests are not required

Test Artifacts

  • Windows
    • Keyman for Windows - build : all tests passed (no artifacts on BuildLevel "build")
    • FirstVoices Keyboards for Windows - build : all tests passed (no artifacts on BuildLevel "build")
    • Text Editor (ARM64) - build : all tests passed (no artifacts on BuildLevel "build")
    • Text Editor (x64) - build : all tests passed (no artifacts on BuildLevel "build")
    • Text Editor (x86) - build : all tests passed (no artifacts on BuildLevel "build")

@mcdurdin
mcdurdin marked this pull request as ready for review August 28, 2026 05:37

@SabineSIL SabineSIL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyman-server keyman-server modified the milestones: A19S36, B19S1 Aug 30, 2026
@mcdurdin
mcdurdin merged commit b7f124a into master Sep 1, 2026
9 checks passed
@mcdurdin
mcdurdin deleted the refactor/windows/16434-rename-to-RefreshModifierState branch September 1, 2026 08:37
@github-project-automation github-project-automation Bot moved this from Todo to Done in Keyman Sep 1, 2026
@keyman-server

Copy link
Copy Markdown
Collaborator

Changes in this pull request will be available for download in Keyman version 19.0.277-alpha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

refactor(windows): rename GetCapsAndNumlockState() to RefreshModifierState()

3 participants