change(developer): deprecate fix, clearcontext, bump max .kmx version to 19.0 - #16445
Merged
mcdurdin merged 2 commits intoSep 1, 2026
Merged
Conversation
…sion to 19.0 Fixes: #14211 Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
Bot
added
developer/
mac/
linux/
common/
developer/compilers/
core/
mcdurdin
requested review from
ermshiperete and
rc-swag
and removed request for
ermshiperete
August 27, 2026 07:26
mcdurdin
changed the title
GetCapsAndNumlockState() to RefreshModifierState()fix, clearcontext, bump max .kmx version to 19.0
Member
Author
|
@rc-swag and @ermshiperete given the potential impact could I get a second review on this one please? |
ermshiperete
approved these changes
Sep 1, 2026
Contributor
There was a problem hiding this comment.
It's a bit confusing to have a file with deprecated in the name when it's actually not deprecated for v17...
Maybe add a comment in the file? Or name the file warn_deprecated_statement-clearcontext_not-deprecated-in-17.kmn ?
Member
Author
There was a problem hiding this comment.
I'll add a comment as a follow-up (want to merge this chain before finishing up)
mcdurdin
deleted the
change/developer/14211-deprecate-fix-clearcontext
branch
September 1, 2026 15:32
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.277-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #14211
Test-bot: skip