fix(developer): validate id and modifiers attributes in Layr compiler - #16456
Merged
mcdurdin merged 1 commit intoSep 2, 2026
Merged
Conversation
Per the spec, the `id` attribute is required for touch layers, and `modifiers` attribute is required for hardware layers. There is ambiguity in the spec at present as to whether they should be allowed for the alternative type. * Validate that the attributes are present where required. * Tighten validation of `modifiers` attribute - it cannot be empty or missing for hardware; "" != "none". * Hint if the attribute is present when it probably shouldn't be (to be potentially raised to warning or error after spec clarified). * Fixup all keyboard3 xml files to conform to spec and eliminate hints. * Add unit tests. * Removed threshold warning for coverage as kmc-ldml is already > 90%. Fixes: #12423
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
srl295
approved these changes
Aug 28, 2026
Base automatically changed from
fix/developer/16454-validate-hardware-layout-count-only-in-layrs
to
master
September 2, 2026 08:59
mcdurdin
deleted the
fix/developer/12423-ldml-validate-layer-attributes
branch
September 2, 2026 08:59
Collaborator
|
Changes in this pull request will be available for download in Keyman version 19.0.278-alpha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the spec, the
idattribute is required for touch layers, andmodifiersattribute is required for hardware layers. There is ambiguity in the spec at present as to whether they should be allowed for the alternative type.modifiersattribute - it cannot be empty or missing for hardware; "" != "none".Fixes: #12423
Test-bot: skip