fix(mac): allow display of package help file linked content 🍎 - #16458
fix(mac): allow display of package help file linked content 🍎#16458sgschantz wants to merge 1 commit into
Conversation
.pdf, .txt and .png files will now be loaded locally when linked from help files in package Fixes: #9628
keymanapp-test-bot
Bot
added
has-user-test
user-test-required
User Test ResultsTest specification and instructions Test Artifacts |
keymanapp-test-bot
Bot
changed the title
Test Specs
Test Results
|
keymanapp-test-bot
Bot
removed
the
user-test-required
| private static let allowedLocalExtensions = ["pdf", "txt", "png", "jpg", "jpeg"] | ||
| private static let allowedMimeTypes = ["application/pdf", "text/plain", "image/jpeg", "image/png"] |
There was a problem hiding this comment.
I am uncomfortable with this. There may be many other file types included, e.g. webp, gif, videos, css, fonts. This is hard to whitelist correctly.
Is this for navigation operations only?
| if let mimeType = navigationResponse.response.mimeType { | ||
| if PackageContentWebView.allowedMimeTypes.contains(mimeType) { | ||
| decisionHandler(.allow) | ||
| return | ||
| } | ||
| } | ||
| decisionHandler(.allow) |
There was a problem hiding this comment.
This seems to be a nothing test? both code paths give decisionHandler(.allow)
4 participants
.pdf, .txt and .png files are loaded locally when linked from help files in package
Fixes: #9628
Build-bot: release:mac
Test-bot: skip
User Testing
Run Keyman Configuration and install the Syriac/Aramaic keyboard
Select the ? icon to open the help for the package
Click on the 'Aramaic (Hebrew layout)' link to load that child page
Click on both 'Font license' text link and the 'Font documentation' PDF link to verify that they load correctly