chore(developer): remove duplicated versioning information from Server - #16478
Open
mcdurdin wants to merge 2 commits into
Conversation
Use `KEYMAN_VERSION` instead of parsing version information. Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required |
mcdurdin
commented
Aug 31, 2026
| */ | ||
| import path from 'node:path'; | ||
| import { extractVersionData } from './version-data.js'; | ||
| // TODO: environment should be just KEYMAN_VERSION |
Member
Author
There was a problem hiding this comment.
This was the trigger for this PR
Server lacks tests at present. Removing version-data tests as no longer relevant meant that there were no tests! So, added environment tests which relate to changes in #16476.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
KEYMAN_VERSIONinstead of parsing version information.Test-bot: skip